From: Christoph Hellwig <hch@lst.de>
To: Michael Kelley <mikelley@microsoft.com>
Cc: hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com,
decui@microsoft.com, tiala@microsoft.com, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] swiotlb: Track and report io_tlb_used high water mark in debugfs
Date: Fri, 7 Apr 2023 07:50:16 +0200 [thread overview]
Message-ID: <20230407055016.GA6803@lst.de> (raw)
In-Reply-To: <1680324300-124563-1-git-send-email-mikelley@microsoft.com>
On Fri, Mar 31, 2023 at 09:45:00PM -0700, Michael Kelley wrote:
> Changes in v3:
> * Do high water mark accounting only when CONFIG_DEBUG_FS=y. As
> as a result, add back the mem_used() function for the "swiotlb
> buffer is full" error message. [Christoph -- I didn't hear back
> whether this approach addresses your concern about one additional
> atomic operation when slots are allocated and again when freed. I've
> gone ahead with this new version, and we can obviously have further
> discussion.]
Still not too happy, but at least debugfs is an interfact we could
remove at any time.
But can you please factor the used_hiwater accounting into two
separate helpers that are udner CONFIG_DEBUG_FS and otherwise
stubbed out, instead of adding the logic directly into
swiotlb_do_find_slots and swiotlb_release_slots?
next prev parent reply other threads:[~2023-04-07 5:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 4:45 [PATCH v3 1/1] swiotlb: Track and report io_tlb_used high water mark in debugfs Michael Kelley
2023-04-07 5:50 ` Christoph Hellwig [this message]
2023-04-07 22:01 ` Michael Kelley (LINUX)
2023-04-11 3:42 ` Christoph Hellwig
2023-04-07 10:55 ` Petr Tesařík
2023-04-07 22:05 ` Michael Kelley (LINUX)
2023-04-11 3:41 ` hch
2023-04-12 17:30 ` Michael Kelley (LINUX)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407055016.GA6803@lst.de \
--to=hch@lst.de \
--cc=decui@microsoft.com \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mikelley@microsoft.com \
--cc=robin.murphy@arm.com \
--cc=tiala@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox