public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: Tom Rix <trix@redhat.com>,
	lars@metafoo.de, angelo.dureghello@timesys.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: set varaiable max5522_channels storage-class-specifier to static
Date: Fri, 7 Apr 2023 19:01:21 +0100	[thread overview]
Message-ID: <20230407190121.7dfb598c@jic23-huawei> (raw)
In-Reply-To: <ee03cecef9139720a9818aa434dd34ae433d8e9d.camel@gmail.com>

On Tue, 04 Apr 2023 08:43:32 +0200
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Mon, 2023-04-03 at 21:38 -0400, Tom Rix wrote:
> > smatch reports
> > drivers/iio/dac/max5522.c:55:28: warning: symbol
> >   'max5522_channels' was not declared. Should it be static?
> > 
> > This variable is only used in one file so it should be static.
> > 
> > Signed-off-by: Tom Rix <trix@redhat.com>
> > ---  
> 
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> 
> 

Applied to the togreg branch of iio.git (pushed out initially as testing)
with tweak in patch title to fix "variable"

Thanks,

Jonathan

      reply	other threads:[~2023-04-07 17:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04  1:38 [PATCH] iio: dac: set varaiable max5522_channels storage-class-specifier to static Tom Rix
2023-04-04  6:43 ` Nuno Sá
2023-04-07 18:01   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230407190121.7dfb598c@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=angelo.dureghello@timesys.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noname.nuno@gmail.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox