* [PATCH] staging: rtl8192e: Fix logical operator continuations
@ 2023-04-08 17:18 Sumitra Sharma
2023-04-11 0:07 ` Alison Schofield
0 siblings, 1 reply; 3+ messages in thread
From: Sumitra Sharma @ 2023-04-08 17:18 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel
Fix logical operator continuation as suggested by Linux kernel
coding-style. Check reported by checkpatch:
CHECK: Logical continuations should be on the previous line
Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
index 5a1cd22f5e25..58ed394202ae 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
@@ -209,8 +209,8 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
&priv->rtllib->pwr_save_ctrl;
if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
- (priv->rtllib->state == RTLLIB_LINKED))
- || (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
+ (priv->rtllib->state == RTLLIB_LINKED)) ||
+ (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
(priv->rtllib->iw_mode == IW_MODE_MASTER))
return;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix logical operator continuations
2023-04-08 17:18 [PATCH] staging: rtl8192e: Fix logical operator continuations Sumitra Sharma
@ 2023-04-11 0:07 ` Alison Schofield
2023-04-11 5:32 ` Sumitra Sharma
0 siblings, 1 reply; 3+ messages in thread
From: Alison Schofield @ 2023-04-11 0:07 UTC (permalink / raw)
To: Sumitra Sharma; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel
On Sat, Apr 08, 2023 at 10:18:03AM -0700, Sumitra Sharma wrote:
> Fix logical operator continuation as suggested by Linux kernel
> coding-style. Check reported by checkpatch:
>
> CHECK: Logical continuations should be on the previous line
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
Hi Sumitra,
That commit message can be explicit, like "Move logical operator
to previous line"
Alison
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> index 5a1cd22f5e25..58ed394202ae 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> @@ -209,8 +209,8 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
> &priv->rtllib->pwr_save_ctrl;
>
> if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
> - (priv->rtllib->state == RTLLIB_LINKED))
> - || (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> + (priv->rtllib->state == RTLLIB_LINKED)) ||
> + (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> (priv->rtllib->iw_mode == IW_MODE_MASTER))
> return;
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix logical operator continuations
2023-04-11 0:07 ` Alison Schofield
@ 2023-04-11 5:32 ` Sumitra Sharma
0 siblings, 0 replies; 3+ messages in thread
From: Sumitra Sharma @ 2023-04-11 5:32 UTC (permalink / raw)
To: Alison Schofield; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel
On Mon, Apr 10, 2023 at 05:07:12PM -0700, Alison Schofield wrote:
> On Sat, Apr 08, 2023 at 10:18:03AM -0700, Sumitra Sharma wrote:
> > Fix logical operator continuation as suggested by Linux kernel
> > coding-style. Check reported by checkpatch:
> >
> > CHECK: Logical continuations should be on the previous line
> >
> > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
>
> Hi Sumitra,
>
> That commit message can be explicit, like "Move logical operator
> to previous line"
>
Hi Alison
Okay I will change it. Thank you.
Regards
Sumitra
> Alison
>
>
> > ---
> > drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> > index 5a1cd22f5e25..58ed394202ae 100644
> > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> > @@ -209,8 +209,8 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
> > &priv->rtllib->pwr_save_ctrl;
> >
> > if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
> > - (priv->rtllib->state == RTLLIB_LINKED))
> > - || (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> > + (priv->rtllib->state == RTLLIB_LINKED)) ||
> > + (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> > (priv->rtllib->iw_mode == IW_MODE_MASTER))
> > return;
> >
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-11 5:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-08 17:18 [PATCH] staging: rtl8192e: Fix logical operator continuations Sumitra Sharma
2023-04-11 0:07 ` Alison Schofield
2023-04-11 5:32 ` Sumitra Sharma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox