From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CEE9C76196 for ; Mon, 10 Apr 2023 09:57:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbjDJJ5m (ORCPT ); Mon, 10 Apr 2023 05:57:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbjDJJ5k (ORCPT ); Mon, 10 Apr 2023 05:57:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33549270D for ; Mon, 10 Apr 2023 02:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681120617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bIev1Ni0k8gVQrBtjaksm0sBj4Jib/zWqJaw/1JzGaY=; b=bICj8Q2BQyDVCIzNayD9sLqCGx8pHwirQTGyklIAByW8qmzNvQe51bsOCu8m8fz1ATkkzv bKhWH5tCTd67ogQjdb47xU7BICFZ1z6m2Dwo+oe9Kganu76QuDc/Ly5+DXy8w8zH9UusTE bVjh1E2LKoN2zhNxyZN1SkuLT4d05Dc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-0U-1ZQgTOFiftZ1rii3rtQ-1; Mon, 10 Apr 2023 05:56:56 -0400 X-MC-Unique: 0U-1ZQgTOFiftZ1rii3rtQ-1 Received: by mail-wr1-f71.google.com with SMTP id r4-20020adfa144000000b002db44581302so535151wrr.7 for ; Mon, 10 Apr 2023 02:56:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681120614; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bIev1Ni0k8gVQrBtjaksm0sBj4Jib/zWqJaw/1JzGaY=; b=6Kxag8VJYCcGUE8P7WVrTaDzYESeQt0zHy1iHeWSgwVoKXWfeyLQCYkTALrTGoaW8g v1jSOIBjAXZKcccp7/hh+jrY+Y5v6eE2B9xg27V2SMOZQtDxsUs03nufrJvKLXIAOi83 QOmwzUgQgw+k/sjdMZIoex8EqBOXjOHHAYtouwQgmvUTf3hxZ0DlOEmoSFkg+L8TI+q7 5cJvIVxNX+WAJcUxdkItAUcs/rvFNTUMGIUNmIyQjY+ku0AC7kykhGXc/TWk/8WNIDrN FT+R/ddDLAvync9ScN57azSngwJbotWuGHK8qHZwn1mnM1H04D5xml1GeOfBckuKhS35 myjw== X-Gm-Message-State: AAQBX9fsV5mwPHqeVtsttU7XW/XLGfld/vD4n0o0rM10sf95oyWuVn5i BPJvROgfMeb+HtS6xF6o84UFWT1F38OXNaX06w+5qMI5FzuW3ghOi7HlM6ZxUJT3pfju1aFrY1k 065fuww70tAK1h+A5fJL7/0Fz X-Received: by 2002:a05:600c:4e44:b0:3ed:de03:7f0a with SMTP id e4-20020a05600c4e4400b003edde037f0amr6709501wmq.10.1681120614486; Mon, 10 Apr 2023 02:56:54 -0700 (PDT) X-Google-Smtp-Source: AKy350aIvGgfLFCNVAdSw6k5gAj7OmN/nORKbwKTw6UxO28aEz4zeHj0RwHxbx+gO7F9M4ln+QKv6w== X-Received: by 2002:a05:600c:4e44:b0:3ed:de03:7f0a with SMTP id e4-20020a05600c4e4400b003edde037f0amr6709497wmq.10.1681120614217; Mon, 10 Apr 2023 02:56:54 -0700 (PDT) Received: from redhat.com ([2.52.31.213]) by smtp.gmail.com with ESMTPSA id u15-20020a05600c210f00b003ee20b4b2dasm13099189wml.46.2023.04.10.02.56.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 02:56:53 -0700 (PDT) Date: Mon, 10 Apr 2023 05:56:49 -0400 From: "Michael S. Tsirkin" To: Guenter Roeck Cc: Krzysztof Kozlowski , Alvaro Karsz , Jason Wang , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jean Delvare , linux-hwmon@vger.kernel.org Subject: Re: [PATCH] vdpa: solidrun: constify pointers to hwmon_channel_info Message-ID: <20230410055634-mutt-send-email-mst@kernel.org> References: <20230407150130.79917-1-krzysztof.kozlowski@linaro.org> <0395eff6-694e-1a2f-de78-8cb9d7b129a7@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0395eff6-694e-1a2f-de78-8cb9d7b129a7@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2023 at 04:08:30PM -0700, Guenter Roeck wrote: > On 4/7/23 08:01, Krzysztof Kozlowski wrote: > > Statically allocated array of pointed to hwmon_channel_info can be made > > const for safety. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > This depends on hwmon core patch: > > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/ > > > > Therefore I propose this should also go via hwmon tree. > > I am not going to apply patches for 10+ subsystems through the hwmon tree. > This can only result in chaos. The dependent patch is available at > > git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const Doesn't it cause build errors or warnings there? > or wait until after the next commit window to apply this patch. > > Thanks, > Guenter > > > > > Cc: Jean Delvare > > Cc: Guenter Roeck > > Cc: linux-hwmon@vger.kernel.org > > --- > > drivers/vdpa/solidrun/snet_hwmon.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/vdpa/solidrun/snet_hwmon.c b/drivers/vdpa/solidrun/snet_hwmon.c > > index e695e36ff753..65304354b34a 100644 > > --- a/drivers/vdpa/solidrun/snet_hwmon.c > > +++ b/drivers/vdpa/solidrun/snet_hwmon.c > > @@ -159,7 +159,7 @@ static const struct hwmon_ops snet_hwmon_ops = { > > .read_string = snet_hwmon_read_string > > }; > > -static const struct hwmon_channel_info *snet_hwmon_info[] = { > > +static const struct hwmon_channel_info * const snet_hwmon_info[] = { > > HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_MAX | HWMON_T_CRIT | HWMON_T_LABEL, > > HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_LABEL), > > HWMON_CHANNEL_INFO(power, HWMON_P_INPUT | HWMON_P_LABEL),