Re: [PATCH v2 0/2] crypto: x86/aesni - Simplify AES key expansion code

Herbert Xu
2024-03-28T10:57:30Z

On Fri, Mar 22, 2024 at 04:04:57PM -0700, Chang S. Bae wrote:
> Previously, V1 [1] was posted to update the aesni_set_key() prototype to
> remove an unnecessary error code return type.
>
> During the review process, it was discovered that both aes_expandkey()
> and the AES-NI glue code redundantly check the key size. V2 includes a
> cleanup to invoke aes_expandkey() immediately if AES-NI is unusable.
>
> Thanks,
> Chang
>
> [1]: https://lore.kernel.org/lkml/20240311213232.128240-1-chang.seok.bae@intel.com/
>
> Chang S. Bae (2):
> crypto: x86/aesni - Rearrange AES key size check
> crypto: x86/aesni - Update aesni_set_key() to return void
>
> arch/x86/crypto/aesni-intel_asm.S | 5 ++---
> arch/x86/crypto/aesni-intel_glue.c | 24 +++++++++++-------------
> 2 files changed, 13 insertions(+), 16 deletions(-)
>
>
> base-commit: e8f897f4afef0031fe618a8e94127a0934896aba
> --
> 2.34.1

All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt