Re: [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes

Sui Jingfeng
2023-06-11T07:03:49Z

Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>

On 2023/6/10 04:17, Rob Herring wrote:
> On Mon, Apr 10, 2023 at 5:26 PM Rob Herring <robh@kernel.org> wrote:
>> Etnaviv doesn't use anything from of_platform.h, but depends on
>> of.h, of_device.h, and platform_device.h which are all implicitly
>> included, but that is going to be removed soon.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
> Ping!

of_device.h already has 'linux/of.h' and 'linux/platform_device.h' included,

Would it be sufficient by simply including linux/of_device.h ?

I'm fine with the above question explained.

```

#include <linux/platform_device.h>
#include <linux/of_platform.h> /* temporary until merge */

#include <linux/of.h>

```

>> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> index 44ca803237a5..c68e83ed5a23 100644
>> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> @@ -6,7 +6,9 @@
>> #include <linux/component.h>
>> #include <linux/dma-mapping.h>
>> #include <linux/module.h>
>> -#include <linux/of_platform.h>
>> +#include <linux/of.h>
>> +#include <linux/of_device.h>
>> +#include <linux/platform_device.h>
>> #include <linux/uaccess.h>
>>
>> #include <drm/drm_debugfs.h>
>> --
>> 2.39.2
>>
--
Jingfeng