From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDB6C77B73 for ; Tue, 11 Apr 2023 15:17:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231183AbjDKPQ7 (ORCPT ); Tue, 11 Apr 2023 11:16:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231177AbjDKPQj (ORCPT ); Tue, 11 Apr 2023 11:16:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 696A5619B; Tue, 11 Apr 2023 08:15:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A39236285C; Tue, 11 Apr 2023 15:14:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C7E3C433D2; Tue, 11 Apr 2023 15:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681226080; bh=3YqIy9422W4j5TAiKhuwgA4sZIXX6+PQPhFS0rtef+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cyirtFO/mCjXYL12aZzM/ARuJs3BAEh/6mAwWNpSNDiHwLJXFmMxnndVk0mdQJ94H QbvIzQk6nPI866muT6LeB+lXXsPmNyqGIl+G/0x+s/OqrPMmyuZJ54cLd5gRwv7kTN 65zNRwUVN7eV+pjUA+OT/8qqLwlgWV3kOwHy1hZM= Date: Tue, 11 Apr 2023 17:14:37 +0200 From: Greg KH To: Lorenz Bauer Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Martin KaFai Lau , ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, shuah@kernel.org, yhs@fb.com, eddyz87@gmail.com, sdf@google.com, error27@gmail.com, iii@linux.ibm.com, memxor@gmail.com, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.2 08/30] selftests/bpf: check that modifier resolves after pointer Message-ID: <2023041100-oblong-enamel-5893@gregkh> References: <20230320005258.1428043-1-sashal@kernel.org> <20230320005258.1428043-8-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 11, 2023 at 04:08:32PM +0100, Lorenz Bauer wrote: > On Tue, Mar 28, 2023 at 11:18 AM Lorenz Bauer wrote: > > > > On Mon, Mar 20, 2023 at 3:48 PM Greg KH wrote: > > > > > > Why would it break? Is that because the test is buggy, or the kernel is > > > buggy? > > > > This test will be fine, but there have been several times when > > selftests/bpf for stable kernel releases didn't actually compile due > > to backported tests. This is because macros we're redefined, etc. > > Unless those also get picked (seems like a sisyphean task) we'll keep > > seeing broken selftests/bpf on stable. > > Hi Greg, Sasha, > > Following up on this since it seems to have fallen through the cracks. I didn't see anything to do here. And selftests should NOT be broken on stable releases, if so, something is wrong as no other subsystem has that happen. confused, greg k-h