public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <jstultz@google.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: John Stultz <jstultz@google.com>,
	Joel Fernandes <joelaf@google.com>,
	Qais Yousef <qyousef@google.com>, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Valentin Schneider <vschneid@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>,
	Zimuzo Ezeozue <zezeozue@google.com>,
	Mel Gorman <mgorman@suse.de>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
	Boqun Feng <boqun.feng@gmail.com>,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH v3 10/14] sched: Unnest ttwu_runnable in prep for proxy-execution
Date: Tue, 11 Apr 2023 04:25:07 +0000	[thread overview]
Message-ID: <20230411042511.1606592-11-jstultz@google.com> (raw)
In-Reply-To: <20230411042511.1606592-1-jstultz@google.com>

Slightly rework ttwu_runnable to minimize the nesting to help
make the proxy-execution changes easier to read.

Should be no logical change here.

Cc: Joel Fernandes <joelaf@google.com>
Cc: Qais Yousef <qyousef@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Valentin Schneider <vschneid@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ben Segall <bsegall@google.com>
Cc: Zimuzo Ezeozue <zezeozue@google.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: Will Deacon <will@kernel.org>
Cc: Waiman Long <longman@redhat.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: "Paul E . McKenney" <paulmck@kernel.org>
Signed-off-by: John Stultz <jstultz@google.com>
---
 kernel/sched/core.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index a9cf8397c601..82a62480d8d7 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3776,18 +3776,20 @@ static int ttwu_runnable(struct task_struct *p, int wake_flags)
 	int ret = 0;
 
 	rq = __task_rq_lock(p, &rf);
-	if (task_on_rq_queued(p)) {
-		if (!task_on_cpu(rq, p)) {
-			/*
-			 * When on_rq && !on_cpu the task is preempted, see if
-			 * it should preempt the task that is current now.
-			 */
-			update_rq_clock(rq);
-			check_preempt_curr(rq, p, wake_flags);
-		}
-		ttwu_do_wakeup(p);
-		ret = 1;
+	if (!task_on_rq_queued(p))
+		goto out_unlock;
+
+	if (!task_on_cpu(rq, p)) {
+		/*
+		 * When on_rq && !on_cpu the task is preempted, see if
+		 * it should preempt the task that is current now.
+		 */
+		update_rq_clock(rq);
+		check_preempt_curr(rq, p, wake_flags);
 	}
+	ttwu_do_wakeup(p);
+	ret = 1;
+out_unlock:
 	__task_rq_unlock(rq, &rf);
 
 	return ret;
-- 
2.40.0.577.gac1e443424-goog


  parent reply	other threads:[~2023-04-11  4:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11  4:24 [PATCH v3 00/14] Generalized Priority Inheritance via Proxy Execution v3 John Stultz
2023-04-11  4:24 ` [PATCH v3 01/14] locking/ww_mutex: Remove wakeups from under mutex::wait_lock John Stultz
2023-04-11  4:24 ` [PATCH v3 02/14] locking/mutex: make mutex::wait_lock irq safe John Stultz
2023-04-11  4:25 ` [PATCH v3 03/14] locking/mutex: Rework task_struct::blocked_on John Stultz
2023-04-11  4:25 ` [PATCH v3 04/14] locking/mutex: Add task_struct::blocked_lock to serialize changes to the blocked_on state John Stultz
2023-04-11  4:25 ` [PATCH v3 05/14] locking/mutex: Add p->blocked_on wrappers John Stultz
2023-04-11  4:25 ` [PATCH v3 06/14] locking/mutex: Expose mutex_owner() John Stultz
2023-04-22 10:36   ` Peter Zijlstra
2023-04-25 14:53     ` John Stultz
2023-04-11  4:25 ` [PATCH v3 07/14] sched: Unify runtime accounting across classes John Stultz
2023-04-11  4:25 ` [PATCH v3 08/14] sched: Replace rq->curr access w/ rq_curr(rq) John Stultz
2023-04-11 14:07   ` kernel test robot
2023-04-11 20:04     ` John Stultz
2023-04-22 10:42   ` Peter Zijlstra
2023-04-25 14:47     ` John Stultz
2023-04-11  4:25 ` [PATCH v3 09/14] sched: Split scheduler execution context John Stultz
2023-04-22 10:13   ` Peter Zijlstra
2023-04-22 10:14   ` Peter Zijlstra
2023-04-25 14:52     ` John Stultz
2023-04-11  4:25 ` John Stultz [this message]
2023-04-11  4:25 ` [PATCH v3 11/14] sched: Add proxy execution John Stultz
2023-04-11  4:25 ` [PATCH v3 12/14] sched/rt: Fix proxy/current (push,pull)ability John Stultz
2023-04-11  4:25 ` [PATCH v3 13/14] sched: Attempt to fix rt/dl load balancing via chain level balance John Stultz
2023-04-11  4:25 ` [PATCH v3 14/14] sched: Fix runtime accounting w/ proxy-execution John Stultz
2023-04-22 11:54 ` [PATCH v3 00/14] Generalized Priority Inheritance via Proxy Execution v3 Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230411042511.1606592-11-jstultz@google.com \
    --to=jstultz@google.com \
    --cc=boqun.feng@gmail.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=joelaf@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=qyousef@google.com \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=will@kernel.org \
    --cc=zezeozue@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox