From: Rob Herring <robh@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Michael Turquette <mturquette@baylibre.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/3] clk: mvebu: Use of_get_cpu_hwid() to read CPU ID
Date: Tue, 11 Apr 2023 09:04:01 -0500 [thread overview]
Message-ID: <20230411140401.GA2963980-robh@kernel.org> (raw)
In-Reply-To: <216176104e507b860e24399bf020d836.sboyd@kernel.org>
On Mon, Apr 10, 2023 at 04:36:21PM -0700, Stephen Boyd wrote:
> Quoting Rob Herring (2023-03-27 11:43:19)
> > Use of_get_cpu_hwid() rather than the open coded reading of the CPU
> > nodes "reg" property. The existing code is in fact wrong as the "reg"
> > address cells size is 2 cells for arm64. The existing code happens to
> > work because the DTS files are wrong as well.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Note this should be marked for stable so that if/when the DTS files are
> > fixed, then at least stable kernels will work. This is untested, so I
> > didn't mark for stable.
>
> That makes it sound like it breaks for existing DTS files. Is that the
> case?
No, if the DTS files are fixed, then they will not work with the
existing code. This change should work for both existing and fixed DTS
files.
Rob
next prev parent reply other threads:[~2023-04-11 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 18:43 [PATCH 0/3] clk: Fix/cleanup mvebu CPU DT node accesses Rob Herring
2023-03-27 18:43 ` [PATCH 1/3] MAINTAINERS: Add Marvell mvebu clock drivers Rob Herring
2023-03-27 21:17 ` Andrew Lunn
2023-03-27 18:43 ` [PATCH 2/3] clk: mvebu: Use of_get_cpu_hwid() to read CPU ID Rob Herring
2023-04-10 23:36 ` Stephen Boyd
2023-04-11 14:04 ` Rob Herring [this message]
2023-03-27 18:43 ` [PATCH 3/3] clk: mvebu: Iterate over possible CPUs instead of DT CPU nodes Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411140401.GA2963980-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox