From: Andreas Kemnade <andreas@kemnade.info>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: pavel@ucw.cz, lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: ROHM BD2606MVV LED driver
Date: Tue, 11 Apr 2023 21:30:44 +0200 [thread overview]
Message-ID: <20230411213044.4bf6dc89@aktux> (raw)
In-Reply-To: <a16a8071-3c67-0f40-d7da-3459f7dc584d@linaro.org>
On Mon, 10 Apr 2023 17:34:00 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
[...]
> > + led-controller@66 {
> > + compatible = "rohm,bd2606mvv";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x66>;
>
> reg is always second property in DTS.
>
> > +
> > + led@0 {
> > + color = <LED_COLOR_ID_RED>;
> > + function = LED_FUNCTION_POWER;
> > + reg = <0x0>;
>
> Ditto
>
hmm, reg also second if no compatible first? I see it usually first in
such cases.
Regards,
Andreas
next prev parent reply other threads:[~2023-04-11 19:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 5:08 [PATCH v2 0/2] leds: Add a driver for the BD2606MVV Andreas Kemnade
2023-04-07 5:08 ` [PATCH v2 1/2] dt-bindings: leds: ROHM BD2606MVV LED driver Andreas Kemnade
2023-04-07 10:00 ` Matti Vaittinen
2023-04-10 15:34 ` Krzysztof Kozlowski
2023-04-11 19:30 ` Andreas Kemnade [this message]
2023-04-12 7:09 ` Krzysztof Kozlowski
2023-04-07 5:08 ` [PATCH v2 2/2] leds: bd2606mvv: Driver for the Rohm 6 Channel i2c " Andreas Kemnade
2023-04-07 10:10 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411213044.4bf6dc89@aktux \
--to=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox