From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 202A5C7619A for ; Wed, 12 Apr 2023 06:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229481AbjDLGsj (ORCPT ); Wed, 12 Apr 2023 02:48:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjDLGsg (ORCPT ); Wed, 12 Apr 2023 02:48:36 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7A804C1B; Tue, 11 Apr 2023 23:48:35 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id E75E568AA6; Wed, 12 Apr 2023 08:48:31 +0200 (CEST) Date: Wed, 12 Apr 2023 08:48:31 +0200 From: Christoph Hellwig To: Krzysztof Kozlowski Cc: Christoph Hellwig , Guenter Roeck , Keith Busch , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Jean Delvare , linux-hwmon@vger.kernel.org Subject: Re: [PATCH] nvme: host: hwmon: constify pointers to hwmon_channel_info Message-ID: <20230412064831.GA20380@lst.de> References: <20230407145845.79557-1-krzysztof.kozlowski@linaro.org> <20230411060900.GD18527@lst.de> <20230411061012.GA18624@lst.de> <0d4d27e6-02e0-09e3-8e99-18b40880961c@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d4d27e6-02e0-09e3-8e99-18b40880961c@linaro.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 11, 2023 at 08:11:41AM +0200, Krzysztof Kozlowski wrote: > The dependency was described in the patch. Guenter also provided > a stable branch with the dependency: Ok. See below for the version with the whitespace and Subject fix I'd like to see. With that: Acked-by: Christoph Hellwig --- >From 882410442b1bb5730f3eec29d8dc9ccda5e92cdb Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski Date: Fri, 7 Apr 2023 16:58:45 +0200 Subject: nvme-hwmon: constify pointers to hwmon_channel_info Statically allocated array of pointed to hwmon_channel_info can be made const for safety. Signed-off-by: Krzysztof Kozlowski --- drivers/nvme/host/hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/hwmon.c b/drivers/nvme/host/hwmon.c index 9e6e56c20ec993..6aa153f3178a60 100644 --- a/drivers/nvme/host/hwmon.c +++ b/drivers/nvme/host/hwmon.c @@ -185,7 +185,7 @@ static umode_t nvme_hwmon_is_visible(const void *_data, return 0; } -static const struct hwmon_channel_info *nvme_hwmon_info[] = { +static const struct hwmon_channel_info *const nvme_hwmon_info[] = { HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ), HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_MAX | HWMON_T_MIN | -- 2.39.2