From: Rob Herring <robh@kernel.org>
To: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Alexandre TORGUE <alexandre.torgue@foss.st.com>,
Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH] dt-bindings: mfd: stm32: Fix STM32F4 DT include file
Date: Wed, 12 Apr 2023 10:03:50 -0500 [thread overview]
Message-ID: <20230412150350.GA2361252-robh@kernel.org> (raw)
In-Reply-To: <20230407201235.1.I483a676579cc7e3ac07e1db649091553743fecc8@changeid>
On Fri, Apr 07, 2023 at 08:12:43PM +0200, Patrick Delaunay wrote:
> Minor cosmetic change, aligned with file in U-Boot:
> - remove extra space
extra blank line really.
Please make the subject reflect what the change is. This doesn't really
'Fix' anything and it's so generic it could be any change. Just 'Remove
double blank line' would be much better and defines the exact change.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
>
> include/dt-bindings/mfd/stm32f4-rcc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/dt-bindings/mfd/stm32f4-rcc.h b/include/dt-bindings/mfd/stm32f4-rcc.h
> index 309e8c79f27b..36448a5619a1 100644
> --- a/include/dt-bindings/mfd/stm32f4-rcc.h
> +++ b/include/dt-bindings/mfd/stm32f4-rcc.h
> @@ -34,7 +34,6 @@
> #define STM32F4_AHB1_RESET(bit) (STM32F4_RCC_AHB1_##bit + (0x10 * 8))
> #define STM32F4_AHB1_CLOCK(bit) (STM32F4_RCC_AHB1_##bit)
>
> -
> /* AHB2 */
> #define STM32F4_RCC_AHB2_DCMI 0
> #define STM32F4_RCC_AHB2_CRYP 4
> --
> 2.25.1
>
prev parent reply other threads:[~2023-04-12 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 18:12 [PATCH] dt-bindings: mfd: stm32: Fix STM32F4 DT include file Patrick Delaunay
2023-04-12 15:03 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412150350.GA2361252-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=patrick.delaunay@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox