From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E94EC77B6E for ; Wed, 12 Apr 2023 15:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230507AbjDLPVd (ORCPT ); Wed, 12 Apr 2023 11:21:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231431AbjDLPVV (ORCPT ); Wed, 12 Apr 2023 11:21:21 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D75A0619A for ; Wed, 12 Apr 2023 08:20:53 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 241DB68AA6; Wed, 12 Apr 2023 17:20:39 +0200 (CEST) Date: Wed, 12 Apr 2023 17:20:38 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next v9 3/3] mm/zswap: delay the initialization of zswap Message-ID: <20230412152038.GA26518@lst.de> References: <20230411093632.822290-1-liushixin2@huawei.com> <20230411093632.822290-4-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230411093632.822290-4-liushixin2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 11, 2023 at 05:36:32PM +0800, Liu Shixin wrote: > Since some users may not use zswap, the zswap_pool is wasted. Save memory > by delaying the initialization of zswap until enabled. > > Signed-off-by: Liu Shixin Looks good: Reviewed-by: Christoph Hellwig