* [PATCH] platform/x86/intel/sdsi: Change mailbox timeout
@ 2023-04-13 1:32 David E. Box
2023-04-13 10:17 ` Ilpo Järvinen
0 siblings, 1 reply; 3+ messages in thread
From: David E. Box @ 2023-04-13 1:32 UTC (permalink / raw)
To: david.e.box, hdegoede, markgross; +Cc: platform-driver-x86, linux-kernel
On some platforms, it may take up to 400ms for the ready bit to be set in a
successful mailbox transaction. Set the timeout to 500ms to cover the worst
case.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
drivers/platform/x86/intel/sdsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
index 9e0ea2cdd704..556e7c6dbb05 100644
--- a/drivers/platform/x86/intel/sdsi.c
+++ b/drivers/platform/x86/intel/sdsi.c
@@ -49,7 +49,7 @@
#define SDSI_MBOX_CMD_SUCCESS 0x40
#define SDSI_MBOX_CMD_TIMEOUT 0x80
-#define MBOX_TIMEOUT_US 2000
+#define MBOX_TIMEOUT_US 500000
#define MBOX_TIMEOUT_ACQUIRE_US 1000
#define MBOX_POLLING_PERIOD_US 100
#define MBOX_ACQUIRE_NUM_RETRIES 5
base-commit: 5b309e80f457ebb41770e0122766825a78cfc11b
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86/intel/sdsi: Change mailbox timeout
2023-04-13 1:32 [PATCH] platform/x86/intel/sdsi: Change mailbox timeout David E. Box
@ 2023-04-13 10:17 ` Ilpo Järvinen
2023-04-17 10:13 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Ilpo Järvinen @ 2023-04-13 10:17 UTC (permalink / raw)
To: David E. Box; +Cc: hdegoede, markgross, platform-driver-x86, LKML
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Wed, 12 Apr 2023, David E. Box wrote:
> On some platforms, it may take up to 400ms for the ready bit to be set in a
> successful mailbox transaction. Set the timeout to 500ms to cover the worst
> case.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
> drivers/platform/x86/intel/sdsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
> index 9e0ea2cdd704..556e7c6dbb05 100644
> --- a/drivers/platform/x86/intel/sdsi.c
> +++ b/drivers/platform/x86/intel/sdsi.c
> @@ -49,7 +49,7 @@
> #define SDSI_MBOX_CMD_SUCCESS 0x40
> #define SDSI_MBOX_CMD_TIMEOUT 0x80
>
> -#define MBOX_TIMEOUT_US 2000
> +#define MBOX_TIMEOUT_US 500000
> #define MBOX_TIMEOUT_ACQUIRE_US 1000
> #define MBOX_POLLING_PERIOD_US 100
> #define MBOX_ACQUIRE_NUM_RETRIES 5
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86/intel/sdsi: Change mailbox timeout
2023-04-13 10:17 ` Ilpo Järvinen
@ 2023-04-17 10:13 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2023-04-17 10:13 UTC (permalink / raw)
To: Ilpo Järvinen, David E. Box; +Cc: markgross, platform-driver-x86, LKML
Hi,
On 4/13/23 12:17, Ilpo Järvinen wrote:
> On Wed, 12 Apr 2023, David E. Box wrote:
>
>> On some platforms, it may take up to 400ms for the ready bit to be set in a
>> successful mailbox transaction. Set the timeout to 500ms to cover the worst
>> case.
>>
>> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
>> ---
>> drivers/platform/x86/intel/sdsi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
>> index 9e0ea2cdd704..556e7c6dbb05 100644
>> --- a/drivers/platform/x86/intel/sdsi.c
>> +++ b/drivers/platform/x86/intel/sdsi.c
>> @@ -49,7 +49,7 @@
>> #define SDSI_MBOX_CMD_SUCCESS 0x40
>> #define SDSI_MBOX_CMD_TIMEOUT 0x80
>>
>> -#define MBOX_TIMEOUT_US 2000
>> +#define MBOX_TIMEOUT_US 500000
>> #define MBOX_TIMEOUT_ACQUIRE_US 1000
>> #define MBOX_POLLING_PERIOD_US 100
>> #define MBOX_ACQUIRE_NUM_RETRIES 5
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thank you both for the patch + review, I've applied this patch
to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-17 10:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-13 1:32 [PATCH] platform/x86/intel/sdsi: Change mailbox timeout David E. Box
2023-04-13 10:17 ` Ilpo Järvinen
2023-04-17 10:13 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox