From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B607C77B73 for ; Thu, 13 Apr 2023 02:39:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229913AbjDMCj1 (ORCPT ); Wed, 12 Apr 2023 22:39:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbjDMCii (ORCPT ); Wed, 12 Apr 2023 22:38:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC8B5869A; Wed, 12 Apr 2023 19:37:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 45A6A63A94; Thu, 13 Apr 2023 02:37:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 067AAC433D2; Thu, 13 Apr 2023 02:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681353456; bh=qhfSTW77Ij2nesFY/gKw6hsMkvyp2+Wd2BeZDFndKUY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VWs8DdvKKthCzestRdHjC2wrkGKimxLZiTJXF/QA8todVfuly1r2Cd60fb9WAsIEV 52qX9OkEDGFublHHJfYtouOLxpwd+ilYP66D3RI4aox7je/GqED1p3n2KyWNOHtBGR noy6te4dNY0lk3vJhw/+xPalq1xOuvVM3yix0T5zU7jKeN+ukFxwOotCO8xQYFu1Q7 1nmD+516kBZvXfqDXal3XY8Zl5a8UJ4AySuEEUqMKYGb5FdaKA1AIVLLqqXN0VsaCC j2r9qIn/pASJQ5uSdOhllaaJxKQQ4w+eeLX1gLiLBvQUfPjCzVkoCPwb1/+q/v243H S057gmrAVwwQA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Patrik=20Dahlstr=C3=B6m?= , Jonathan Cameron , Sasha Levin , jic23@kernel.org, linux-iio@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 4/8] iio: adc: palmas_gpadc: fix NULL dereference on rmmod Date: Wed, 12 Apr 2023 22:37:21 -0400 Message-Id: <20230413023727.74875-4-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230413023727.74875-1-sashal@kernel.org> References: <20230413023727.74875-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Patrik Dahlström [ Upstream commit 49f76c499d38bf67803438eee88c8300d0f6ce09 ] Calling dev_to_iio_dev() on a platform device pointer is undefined and will make adc NULL. Signed-off-by: Patrik Dahlström Link: https://lore.kernel.org/r/20230313205029.1881745-1-risca@dalakolonin.se Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/adc/palmas_gpadc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c index f9c8385c72d3d..496aab94570a1 100644 --- a/drivers/iio/adc/palmas_gpadc.c +++ b/drivers/iio/adc/palmas_gpadc.c @@ -638,7 +638,7 @@ static int palmas_gpadc_probe(struct platform_device *pdev) static int palmas_gpadc_remove(struct platform_device *pdev) { - struct iio_dev *indio_dev = dev_to_iio_dev(&pdev->dev); + struct iio_dev *indio_dev = dev_get_drvdata(&pdev->dev); struct palmas_gpadc *adc = iio_priv(indio_dev); if (adc->wakeup1_enable || adc->wakeup2_enable) -- 2.39.2