From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38CBEC77B71 for ; Thu, 13 Apr 2023 02:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231363AbjDMClo (ORCPT ); Wed, 12 Apr 2023 22:41:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231408AbjDMClY (ORCPT ); Wed, 12 Apr 2023 22:41:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D529E7ECA; Wed, 12 Apr 2023 19:39:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D211B63AAB; Thu, 13 Apr 2023 02:38:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90836C433EF; Thu, 13 Apr 2023 02:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681353501; bh=XGuQua3qFkKXR113AHzPtaUgmD0Q6HpJpVp/TOacGUs=; h=From:To:Cc:Subject:Date:From; b=nGiA99xhQgizLZeRU/VcMhAjymzMwrM84tXXx8mgCequHl/a+4+z5doWxDeZivgyk Ip6ue6H5P6O1Dgpwo4Ah9fTGN9dlzOCEf0OXtiepEFr58LDMXGykpX2p3kBx25hkmR MqyoFr1oQXoRzIcxBACZgyVPqcBc41kgBM17uqA43yOgtaAZU4+JCw/Fw9G1L1u+7Q xae2XYuJBFFfv069DZUbEGHPNm2iJhy8KGpkh9piKp5+IK4R7LyQ8J+ktt2c/2Hu1M 0Ac4W0ruIc+kYgbTmyw336GN2iLTsoBIIcda2iLtClQg27hcFFXAw49DZH3kqOiYZb BoP/DWjzRWECw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Patrik=20Dahlstr=C3=B6m?= , Jonathan Cameron , Sasha Levin , jic23@kernel.org, linux-iio@vger.kernel.org Subject: [PATCH AUTOSEL 4.14] iio: adc: palmas_gpadc: fix NULL dereference on rmmod Date: Wed, 12 Apr 2023 22:38:16 -0400 Message-Id: <20230413023818.75139-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Patrik Dahlström [ Upstream commit 49f76c499d38bf67803438eee88c8300d0f6ce09 ] Calling dev_to_iio_dev() on a platform device pointer is undefined and will make adc NULL. Signed-off-by: Patrik Dahlström Link: https://lore.kernel.org/r/20230313205029.1881745-1-risca@dalakolonin.se Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/adc/palmas_gpadc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c index f5218461ae255..f422df4daadcb 100644 --- a/drivers/iio/adc/palmas_gpadc.c +++ b/drivers/iio/adc/palmas_gpadc.c @@ -634,7 +634,7 @@ static int palmas_gpadc_probe(struct platform_device *pdev) static int palmas_gpadc_remove(struct platform_device *pdev) { - struct iio_dev *indio_dev = dev_to_iio_dev(&pdev->dev); + struct iio_dev *indio_dev = dev_get_drvdata(&pdev->dev); struct palmas_gpadc *adc = iio_priv(indio_dev); if (adc->wakeup1_enable || adc->wakeup2_enable) -- 2.39.2