From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Tina Zhang <tina.zhang@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 14/17] iommu/vt-d: Remove BUG_ON when domain->pgd is NULL
Date: Thu, 13 Apr 2023 12:06:42 +0800 [thread overview]
Message-ID: <20230413040645.46157-15-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20230413040645.46157-1-baolu.lu@linux.intel.com>
From: Tina Zhang <tina.zhang@intel.com>
When performing domain_context_mapping or getting dma_pte of a pfn, the
availability of the domain page table directory is ensured. Therefore,
the domain->pgd checkings are unnecessary.
Signed-off-by: Tina Zhang <tina.zhang@intel.com>
Link: https://lore.kernel.org/r/20230406065944.2773296-5-tina.zhang@intel.com
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/intel/iommu.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index dd61bb554aa7..f11347a590d7 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -915,8 +915,6 @@ static struct dma_pte *pfn_to_dma_pte(struct dmar_domain *domain,
int level = agaw_to_level(domain->agaw);
int offset;
- BUG_ON(!domain->pgd);
-
if (!domain_pfn_supported(domain, pfn))
/* Address beyond IOMMU's addressing capabilities. */
return NULL;
@@ -1910,8 +1908,6 @@ static int domain_context_mapping_one(struct dmar_domain *domain,
pr_debug("Set context mapping for %02x:%02x.%d\n",
bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
- BUG_ON(!domain->pgd);
-
spin_lock(&iommu->lock);
ret = -ENOMEM;
context = iommu_context_addr(iommu, bus, devfn, 1);
--
2.34.1
next prev parent reply other threads:[~2023-04-13 4:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 4:06 [PATCH v2 00/17] [PULL REQUEST] Intel IOMMU updates for Linux v6.4 Lu Baolu
2023-04-13 4:06 ` [PATCH v2 01/17] dmaengine: idxd: Add enable/disable device IOPF feature Lu Baolu
2023-04-13 4:06 ` [PATCH v2 02/17] iommu/vt-d: Allow SVA with device-specific IOPF Lu Baolu
2023-04-13 4:06 ` [PATCH v2 03/17] iommu/vt-d: Move iopf code from SVA to IOPF enabling path Lu Baolu
2023-04-13 4:06 ` [PATCH v2 04/17] iommu/vt-d: Move pfsid and ats_qdep calculation to device probe path Lu Baolu
2023-04-13 4:06 ` [PATCH v2 05/17] iommu/vt-d: Move PRI handling to IOPF feature path Lu Baolu
2023-04-13 4:06 ` [PATCH v2 06/17] iommu/vt-d: Remove unnecessary checks in iopf disabling path Lu Baolu
2023-04-13 4:06 ` [PATCH v2 07/17] iommu/vt-d: Do not use GFP_ATOMIC when not needed Lu Baolu
2023-04-13 4:06 ` [PATCH v2 08/17] iommu/vt-d: Remove extern from function prototypes Lu Baolu
2023-04-13 4:06 ` [PATCH v2 09/17] iommu/vt-d: Use non-privileged mode for all PASIDs Lu Baolu
2023-04-13 4:06 ` [PATCH v2 10/17] iommu/vt-d: Remove PASID supervisor request support Lu Baolu
2023-04-13 4:06 ` [PATCH v2 11/17] iommu/vt-d: Make size of operands same in bitwise operations Lu Baolu
2023-04-13 4:06 ` [PATCH v2 12/17] iommu/vt-d: Remove BUG_ON on checking valid pfn range Lu Baolu
2023-04-13 4:06 ` [PATCH v2 13/17] iommu/vt-d: Remove BUG_ON in handling iotlb cache invalidation Lu Baolu
2023-04-13 4:06 ` Lu Baolu [this message]
2023-04-13 4:06 ` [PATCH v2 15/17] iommu/vt-d: Remove BUG_ON in map/unmap() Lu Baolu
2023-04-13 4:06 ` [PATCH v2 16/17] iommu/vt-d: Remove a useless BUG_ON(dev->is_virtfn) Lu Baolu
2023-04-13 4:06 ` [PATCH v2 17/17] iommu/vt-d: Remove BUG_ON in dmar_insert_dev_scope() Lu Baolu
2023-04-13 10:06 ` [PATCH v2 00/17] [PULL REQUEST] Intel IOMMU updates for Linux v6.4 Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413040645.46157-15-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tina.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox