From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Tina Zhang <tina.zhang@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 07/17] iommu/vt-d: Do not use GFP_ATOMIC when not needed
Date: Thu, 13 Apr 2023 12:06:35 +0800 [thread overview]
Message-ID: <20230413040645.46157-8-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20230413040645.46157-1-baolu.lu@linux.intel.com>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
There is no need to use GFP_ATOMIC here. GFP_KERNEL is already used for
some other memory allocations just a few lines above.
Commit e3a981d61d15 ("iommu/vt-d: Convert allocations to GFP_KERNEL") has
changed the other memory allocation flags.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/e2a8a1019ffc8a86b4b4ed93def3623f60581274.1675542576.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/intel/irq_remapping.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel/irq_remapping.c b/drivers/iommu/intel/irq_remapping.c
index df9e261af0b5..a1b987335b31 100644
--- a/drivers/iommu/intel/irq_remapping.c
+++ b/drivers/iommu/intel/irq_remapping.c
@@ -548,7 +548,7 @@ static int intel_setup_irq_remapping(struct intel_iommu *iommu)
goto out_free_table;
}
- bitmap = bitmap_zalloc(INTR_REMAP_TABLE_ENTRIES, GFP_ATOMIC);
+ bitmap = bitmap_zalloc(INTR_REMAP_TABLE_ENTRIES, GFP_KERNEL);
if (bitmap == NULL) {
pr_err("IR%d: failed to allocate bitmap\n", iommu->seq_id);
goto out_free_pages;
--
2.34.1
next prev parent reply other threads:[~2023-04-13 4:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 4:06 [PATCH v2 00/17] [PULL REQUEST] Intel IOMMU updates for Linux v6.4 Lu Baolu
2023-04-13 4:06 ` [PATCH v2 01/17] dmaengine: idxd: Add enable/disable device IOPF feature Lu Baolu
2023-04-13 4:06 ` [PATCH v2 02/17] iommu/vt-d: Allow SVA with device-specific IOPF Lu Baolu
2023-04-13 4:06 ` [PATCH v2 03/17] iommu/vt-d: Move iopf code from SVA to IOPF enabling path Lu Baolu
2023-04-13 4:06 ` [PATCH v2 04/17] iommu/vt-d: Move pfsid and ats_qdep calculation to device probe path Lu Baolu
2023-04-13 4:06 ` [PATCH v2 05/17] iommu/vt-d: Move PRI handling to IOPF feature path Lu Baolu
2023-04-13 4:06 ` [PATCH v2 06/17] iommu/vt-d: Remove unnecessary checks in iopf disabling path Lu Baolu
2023-04-13 4:06 ` Lu Baolu [this message]
2023-04-13 4:06 ` [PATCH v2 08/17] iommu/vt-d: Remove extern from function prototypes Lu Baolu
2023-04-13 4:06 ` [PATCH v2 09/17] iommu/vt-d: Use non-privileged mode for all PASIDs Lu Baolu
2023-04-13 4:06 ` [PATCH v2 10/17] iommu/vt-d: Remove PASID supervisor request support Lu Baolu
2023-04-13 4:06 ` [PATCH v2 11/17] iommu/vt-d: Make size of operands same in bitwise operations Lu Baolu
2023-04-13 4:06 ` [PATCH v2 12/17] iommu/vt-d: Remove BUG_ON on checking valid pfn range Lu Baolu
2023-04-13 4:06 ` [PATCH v2 13/17] iommu/vt-d: Remove BUG_ON in handling iotlb cache invalidation Lu Baolu
2023-04-13 4:06 ` [PATCH v2 14/17] iommu/vt-d: Remove BUG_ON when domain->pgd is NULL Lu Baolu
2023-04-13 4:06 ` [PATCH v2 15/17] iommu/vt-d: Remove BUG_ON in map/unmap() Lu Baolu
2023-04-13 4:06 ` [PATCH v2 16/17] iommu/vt-d: Remove a useless BUG_ON(dev->is_virtfn) Lu Baolu
2023-04-13 4:06 ` [PATCH v2 17/17] iommu/vt-d: Remove BUG_ON in dmar_insert_dev_scope() Lu Baolu
2023-04-13 10:06 ` [PATCH v2 00/17] [PULL REQUEST] Intel IOMMU updates for Linux v6.4 Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413040645.46157-8-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tina.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox