From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10BD4C77B6C for ; Thu, 13 Apr 2023 05:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229616AbjDMFVA (ORCPT ); Thu, 13 Apr 2023 01:21:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjDMFUz (ORCPT ); Thu, 13 Apr 2023 01:20:55 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 39039118 for ; Wed, 12 Apr 2023 22:20:52 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 933B580CD; Thu, 13 Apr 2023 05:20:51 +0000 (UTC) Date: Thu, 13 Apr 2023 08:20:50 +0300 From: Tony Lindgren To: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= Cc: linux-arm-kernel@lists.infradead.org, Russell King , Nick Terrell , Arnd Bergmann , Geert Uytterhoeven , Linus Walleij , Sebastian Reichel , Nick Hawkins , Christophe Leroy , Florian Fainelli , Nick Desaulniers , Xin Li , Seung-Woo Kim , Paul Bolle , Bart Van Assche , linux-kernel@vger.kernel.org, "Russell King (Oracle)" Subject: Re: [PATCH 1/3] ARM: compressed: Pass the actual output length to the decompressor Message-ID: <20230413052050.GB9837@atomide.com> References: <20230412212126.3966502-1-j.neuschaefer@gmx.net> <20230412212126.3966502-2-j.neuschaefer@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230412212126.3966502-2-j.neuschaefer@gmx.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jonathan Neuschäfer [230412 21:22]: > --- a/arch/arm/boot/compressed/misc.c > +++ b/arch/arm/boot/compressed/misc.c > +static u32 get_inflated_image_size(void) > +{ > + return get_unaligned_le32(input_data_end - 4); > +} Just something to check.. This patch should not picked for the old stable kernels that did not have the uncompressed image size at the end. Maybe the patch should have a Depends-on tag to prevent possible issues? Other than that looks good to me: Reviewed-by: Tony Lindgren