From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAD6FC77B61 for ; Thu, 13 Apr 2023 16:13:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbjDMQNw (ORCPT ); Thu, 13 Apr 2023 12:13:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbjDMQNv (ORCPT ); Thu, 13 Apr 2023 12:13:51 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F00B83; Thu, 13 Apr 2023 09:13:50 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Py4MG3GBlz6J6kG; Fri, 14 Apr 2023 00:11:22 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 13 Apr 2023 17:13:48 +0100 Date: Thu, 13 Apr 2023 17:13:47 +0100 From: Jonathan Cameron To: Terry Bowman CC: , , , , , , , , , , Mahesh J Salgaonkar , Oliver O'Halloran , Subject: Re: [PATCH v3 3/6] PCI/AER: Export cper_print_aer() for use by modules Message-ID: <20230413171347.00003f1d@Huawei.com> In-Reply-To: <20230411180302.2678736-4-terry.bowman@amd.com> References: <20230411180302.2678736-1-terry.bowman@amd.com> <20230411180302.2678736-4-terry.bowman@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Apr 2023 13:02:59 -0500 Terry Bowman wrote: > The CXL driver plans to use cper_print_aer() for restricted CXL host > (RCH) logging. cper_print_aer() is not exported and as a result is not > available to the CXL driver or other loadable modules. Export > cper_print_aer() making it available to CXL and other loadable modules. > > Signed-off-by: Terry Bowman > Cc: Mahesh J Salgaonkar > Cc: "Oliver O'Halloran" > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org Seems reasonable. FWIW Reviewed-by: Jonathan Cameron > --- > drivers/pci/pcie/aer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index f6c24ded134c..7a25b62d9e01 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -812,6 +812,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity, > trace_aer_event(dev_name(&dev->dev), (status & ~mask), > aer_severity, tlp_header_valid, &aer->header_log); > } > +EXPORT_SYMBOL_GPL(cper_print_aer); > #endif > > /**