From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC6C4C77B61 for ; Thu, 13 Apr 2023 15:06:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231491AbjDMPGZ (ORCPT ); Thu, 13 Apr 2023 11:06:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231514AbjDMPGJ (ORCPT ); Thu, 13 Apr 2023 11:06:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBAB48A74 for ; Thu, 13 Apr 2023 08:06:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 68CF863F65 for ; Thu, 13 Apr 2023 15:06:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C1F6C433D2; Thu, 13 Apr 2023 15:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681398363; bh=BgPD03K8VDv3X6el3A2XpsePodKHLI7seCgCr9oEcRg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AXMOMN5421vR+3lakIaI6HLBf4kR6ExrBiIxQRG2NyEwC77BFSDP/tRWlIInUQO1J hHY2PHJBlhTSM2eNhvTVAiBMzuUc4MqdOAFpXoAbL9wDOqTKoM26i7LO1FV/OpR4Ip td63zCFfTgPkcq0tHDKJZzpV/ELL/1aIov4ulDt8= Date: Thu, 13 Apr 2023 17:06:01 +0200 From: Greg KH To: Chuang Zhang Cc: arve@android.com, tkjos@android.com, maco@android.com, joel@joelfernandes.org, brauner@kernel.org, cmllamas@google.com, surenb@google.com, linux-kernel@vger.kernel.org, Chuang Zhang Subject: Re: [PATCH] Binder: Add timestamp and async from pid/tid to transaction record Message-ID: <2023041324-molecule-clad-b580@gregkh> References: <20230413104047.388861-1-zhangchuang3@xiaomi.corp-partner.google.com> <2023041302-uncut-tutor-0e6e@gregkh> <2023041359-marine-uninsured-bae9@gregkh> <2023041347-abdominal-bronze-34be@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2023 at 09:03:08PM +0800, Chuang Zhang wrote: > On Thu, Apr 13, 2023 at 8:36 PM Greg KH wrote: > > > On Thu, Apr 13, 2023 at 08:34:06PM +0800, Chuang Zhang wrote: > > > On Thu, Apr 13, 2023 at 8:17 PM Greg KH > > wrote: > > > > And how are pid namespaces being handled here? I know it's just > > > > debugging data but showing a pid from the wrong namespace probably > > would > > > > not be a good idea as it might get confusing quickly. > > > > > > > [chuang] Do you have any good suggestions? thanks > > > > I do not know what you are using this debug information for, nor how or > > if Android uses pid namespaces (I think it does?) > > > [chuang] > So can I use (struct binder_thread *async_from) instead ? > and get the corresponding pid and tid through the following way: > async_from->proc->pid > async_from->pid I don't know, try it and see! I'm not quite sure what debugging information you can get here with the pid, nor what you intend to do with it, so I can't answer this very well, sorry. thanks, greg k-h