* Re: [PATCH] Subject: drivers:i2c:busses:i2c-qup.c: Add missing unwind goto in qup_i2c_probe()
2023-04-16 16:41 [PATCH] Subject: drivers:i2c:busses:i2c-qup.c: Add missing unwind goto in qup_i2c_probe() Shuai Jiang
@ 2023-04-16 18:28 ` kernel test robot
2023-04-17 11:02 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-04-16 18:28 UTC (permalink / raw)
To: Shuai Jiang, Andy Gross, Bjorn Andersson, Konrad Dybcio
Cc: oe-kbuild-all, linux-arm-msm, linux-i2c, linux-kernel,
hust-os-kernel-patches, Shuai Jiang
Hi Shuai,
kernel test robot noticed the following build warnings:
[auto build test WARNING on wsa/i2c/for-next]
[also build test WARNING on linus/master v6.3-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shuai-Jiang/Subject-drivers-i2c-busses-i2c-qup-c-Add-missing-unwind-goto-in-qup_i2c_probe/20230417-004243
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
patch link: https://lore.kernel.org/r/20230416164146.7750-1-d202180596%40hust.edu.cn
patch subject: [PATCH] Subject: drivers:i2c:busses:i2c-qup.c: Add missing unwind goto in qup_i2c_probe()
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230417/202304170236.7BwOMXCa-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/2f61e419c04ee41517d9543a5c6a97e3e392cd5e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Shuai-Jiang/Subject-drivers-i2c-busses-i2c-qup-c-Add-missing-unwind-goto-in-qup_i2c_probe/20230417-004243
git checkout 2f61e419c04ee41517d9543a5c6a97e3e392cd5e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/i2c/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304170236.7BwOMXCa-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/i2c/busses/i2c-qup.c: In function 'qup_i2c_probe':
>> drivers/i2c/busses/i2c-qup.c:1760:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
1760 | if (IS_ERR(qup->base))
| ^~
drivers/i2c/busses/i2c-qup.c:1762:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
1762 | ret = PTR_ERR(qup->base);
| ^~~
drivers/i2c/busses/i2c-qup.c:1766:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
1766 | if (qup->irq < 0)
| ^~
drivers/i2c/busses/i2c-qup.c:1768:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
1768 | ret = PTR_ERR(qup->irq);
| ^~~
>> drivers/i2c/busses/i2c-qup.c:1768:34: warning: passing argument 1 of 'PTR_ERR' makes pointer from integer without a cast [-Wint-conversion]
1768 | ret = PTR_ERR(qup->irq);
| ~~~^~~~~
| |
| int
In file included from include/linux/kernfs.h:9,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/of.h:17,
from include/linux/irqdomain.h:36,
from include/linux/acpi.h:13,
from drivers/i2c/busses/i2c-qup.c:8:
include/linux/err.h:29:61: note: expected 'const void *' but argument is of type 'int'
29 | static inline long __must_check PTR_ERR(__force const void *ptr)
| ~~~~~~~~~~~~^~~
vim +/if +1760 drivers/i2c/busses/i2c-qup.c
902a91a02bdf02 Austin Christ 2018-05-10 1656
10c5a8425968f8 Bjorn Andersson 2014-03-13 1657 static int qup_i2c_probe(struct platform_device *pdev)
10c5a8425968f8 Bjorn Andersson 2014-03-13 1658 {
10c5a8425968f8 Bjorn Andersson 2014-03-13 1659 static const int blk_sizes[] = {4, 16, 32};
10c5a8425968f8 Bjorn Andersson 2014-03-13 1660 struct qup_i2c_dev *qup;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1661 unsigned long one_bit_t;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1662 u32 io_mode, hw_ver, size;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1663 int ret, fs_div, hs_div;
515da746983bc6 Naveen Kaje 2016-10-11 1664 u32 src_clk_freq = DEFAULT_SRC_CLK;
515da746983bc6 Naveen Kaje 2016-10-11 1665 u32 clk_freq = DEFAULT_CLK_FREQ;
9cedf3b2f09946 Sricharan R 2016-02-22 1666 int blocks;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1667 bool is_qup_v1;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1668
10c5a8425968f8 Bjorn Andersson 2014-03-13 1669 qup = devm_kzalloc(&pdev->dev, sizeof(*qup), GFP_KERNEL);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1670 if (!qup)
10c5a8425968f8 Bjorn Andersson 2014-03-13 1671 return -ENOMEM;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1672
10c5a8425968f8 Bjorn Andersson 2014-03-13 1673 qup->dev = &pdev->dev;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1674 init_completion(&qup->xfer);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1675 platform_set_drvdata(pdev, qup);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1676
d9f52281bc09bd Austin Christ 2018-05-10 1677 if (scl_freq) {
d9f52281bc09bd Austin Christ 2018-05-10 1678 dev_notice(qup->dev, "Using override frequency of %u\n", scl_freq);
d9f52281bc09bd Austin Christ 2018-05-10 1679 clk_freq = scl_freq;
d9f52281bc09bd Austin Christ 2018-05-10 1680 } else {
515da746983bc6 Naveen Kaje 2016-10-11 1681 ret = device_property_read_u32(qup->dev, "clock-frequency", &clk_freq);
515da746983bc6 Naveen Kaje 2016-10-11 1682 if (ret) {
515da746983bc6 Naveen Kaje 2016-10-11 1683 dev_notice(qup->dev, "using default clock-frequency %d",
515da746983bc6 Naveen Kaje 2016-10-11 1684 DEFAULT_CLK_FREQ);
515da746983bc6 Naveen Kaje 2016-10-11 1685 }
d9f52281bc09bd Austin Christ 2018-05-10 1686 }
10c5a8425968f8 Bjorn Andersson 2014-03-13 1687
191424bb6166f6 Sricharan R 2016-01-19 1688 if (of_device_is_compatible(pdev->dev.of_node, "qcom,i2c-qup-v1.1.1")) {
191424bb6166f6 Sricharan R 2016-01-19 1689 qup->adap.algo = &qup_i2c_algo;
191424bb6166f6 Sricharan R 2016-01-19 1690 qup->adap.quirks = &qup_i2c_quirks;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1691 is_qup_v1 = true;
191424bb6166f6 Sricharan R 2016-01-19 1692 } else {
191424bb6166f6 Sricharan R 2016-01-19 1693 qup->adap.algo = &qup_i2c_algo_v2;
de82bb43185558 Wolfram Sang 2018-07-23 1694 qup->adap.quirks = &qup_i2c_quirks_v2;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1695 is_qup_v1 = false;
902a91a02bdf02 Austin Christ 2018-05-10 1696 if (acpi_match_device(qup_i2c_acpi_match, qup->dev))
902a91a02bdf02 Austin Christ 2018-05-10 1697 goto nodma;
902a91a02bdf02 Austin Christ 2018-05-10 1698 else
9cedf3b2f09946 Sricharan R 2016-02-22 1699 ret = qup_i2c_req_dma(qup);
9cedf3b2f09946 Sricharan R 2016-02-22 1700
9cedf3b2f09946 Sricharan R 2016-02-22 1701 if (ret == -EPROBE_DEFER)
9cedf3b2f09946 Sricharan R 2016-02-22 1702 goto fail_dma;
9cedf3b2f09946 Sricharan R 2016-02-22 1703 else if (ret != 0)
9cedf3b2f09946 Sricharan R 2016-02-22 1704 goto nodma;
9cedf3b2f09946 Sricharan R 2016-02-22 1705
6f2f0f6465acbd Abhishek Sahu 2018-03-12 1706 qup->max_xfer_sg_len = (MX_BLOCKS << 1);
6f2f0f6465acbd Abhishek Sahu 2018-03-12 1707 blocks = (MX_DMA_BLOCKS << 1) + 1;
a86854d0c599b3 Kees Cook 2018-06-12 1708 qup->btx.sg = devm_kcalloc(&pdev->dev,
a86854d0c599b3 Kees Cook 2018-06-12 1709 blocks, sizeof(*qup->btx.sg),
9cedf3b2f09946 Sricharan R 2016-02-22 1710 GFP_KERNEL);
9cedf3b2f09946 Sricharan R 2016-02-22 1711 if (!qup->btx.sg) {
9cedf3b2f09946 Sricharan R 2016-02-22 1712 ret = -ENOMEM;
9cedf3b2f09946 Sricharan R 2016-02-22 1713 goto fail_dma;
9cedf3b2f09946 Sricharan R 2016-02-22 1714 }
9cedf3b2f09946 Sricharan R 2016-02-22 1715 sg_init_table(qup->btx.sg, blocks);
9cedf3b2f09946 Sricharan R 2016-02-22 1716
a86854d0c599b3 Kees Cook 2018-06-12 1717 qup->brx.sg = devm_kcalloc(&pdev->dev,
a86854d0c599b3 Kees Cook 2018-06-12 1718 blocks, sizeof(*qup->brx.sg),
9cedf3b2f09946 Sricharan R 2016-02-22 1719 GFP_KERNEL);
9cedf3b2f09946 Sricharan R 2016-02-22 1720 if (!qup->brx.sg) {
9cedf3b2f09946 Sricharan R 2016-02-22 1721 ret = -ENOMEM;
9cedf3b2f09946 Sricharan R 2016-02-22 1722 goto fail_dma;
9cedf3b2f09946 Sricharan R 2016-02-22 1723 }
9cedf3b2f09946 Sricharan R 2016-02-22 1724 sg_init_table(qup->brx.sg, blocks);
9cedf3b2f09946 Sricharan R 2016-02-22 1725
9cedf3b2f09946 Sricharan R 2016-02-22 1726 /* 2 tag bytes for each block + 5 for start, stop tags */
9cedf3b2f09946 Sricharan R 2016-02-22 1727 size = blocks * 2 + 5;
9cedf3b2f09946 Sricharan R 2016-02-22 1728
685983f4decc5f Sricharan R 2016-06-10 1729 qup->start_tag.start = devm_kzalloc(&pdev->dev,
685983f4decc5f Sricharan R 2016-06-10 1730 size, GFP_KERNEL);
9cedf3b2f09946 Sricharan R 2016-02-22 1731 if (!qup->start_tag.start) {
9cedf3b2f09946 Sricharan R 2016-02-22 1732 ret = -ENOMEM;
9cedf3b2f09946 Sricharan R 2016-02-22 1733 goto fail_dma;
9cedf3b2f09946 Sricharan R 2016-02-22 1734 }
9cedf3b2f09946 Sricharan R 2016-02-22 1735
685983f4decc5f Sricharan R 2016-06-10 1736 qup->brx.tag.start = devm_kzalloc(&pdev->dev, 2, GFP_KERNEL);
9cedf3b2f09946 Sricharan R 2016-02-22 1737 if (!qup->brx.tag.start) {
9cedf3b2f09946 Sricharan R 2016-02-22 1738 ret = -ENOMEM;
9cedf3b2f09946 Sricharan R 2016-02-22 1739 goto fail_dma;
191424bb6166f6 Sricharan R 2016-01-19 1740 }
191424bb6166f6 Sricharan R 2016-01-19 1741
685983f4decc5f Sricharan R 2016-06-10 1742 qup->btx.tag.start = devm_kzalloc(&pdev->dev, 2, GFP_KERNEL);
9cedf3b2f09946 Sricharan R 2016-02-22 1743 if (!qup->btx.tag.start) {
9cedf3b2f09946 Sricharan R 2016-02-22 1744 ret = -ENOMEM;
9cedf3b2f09946 Sricharan R 2016-02-22 1745 goto fail_dma;
9cedf3b2f09946 Sricharan R 2016-02-22 1746 }
9cedf3b2f09946 Sricharan R 2016-02-22 1747 qup->is_dma = true;
9cedf3b2f09946 Sricharan R 2016-02-22 1748 }
9cedf3b2f09946 Sricharan R 2016-02-22 1749
9cedf3b2f09946 Sricharan R 2016-02-22 1750 nodma:
109b8c42b7e28d Austin Christ 2018-05-10 1751 /* We support frequencies up to FAST Mode Plus (1MHz) */
90224e6468e15d Andy Shevchenko 2020-03-24 1752 if (!clk_freq || clk_freq > I2C_MAX_FAST_MODE_PLUS_FREQ) {
10c5a8425968f8 Bjorn Andersson 2014-03-13 1753 dev_err(qup->dev, "clock frequency not supported %d\n",
10c5a8425968f8 Bjorn Andersson 2014-03-13 1754 clk_freq);
2f61e419c04ee4 Shuai Jiang 2023-04-17 1755 ret = -EINVAL;
2f61e419c04ee4 Shuai Jiang 2023-04-17 1756 goto fail_dma;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1757 }
10c5a8425968f8 Bjorn Andersson 2014-03-13 1758
e0442d76213981 Dejin Zheng 2020-04-09 1759 qup->base = devm_platform_ioremap_resource(pdev, 0);
10c5a8425968f8 Bjorn Andersson 2014-03-13 @1760 if (IS_ERR(qup->base))
2f61e419c04ee4 Shuai Jiang 2023-04-17 1761 dev_err(qup->dev, "Could not get qup_i2c_dev base ptr\n");
2f61e419c04ee4 Shuai Jiang 2023-04-17 1762 ret = PTR_ERR(qup->base);
2f61e419c04ee4 Shuai Jiang 2023-04-17 1763 goto fail_dma;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1764
10c5a8425968f8 Bjorn Andersson 2014-03-13 1765 qup->irq = platform_get_irq(pdev, 0);
e42688ed5cf593 Dejin Zheng 2020-04-16 1766 if (qup->irq < 0)
2f61e419c04ee4 Shuai Jiang 2023-04-17 1767 dev_err(qup->dev, "qup_i2c_dev irq ptr less than zero\n");
2f61e419c04ee4 Shuai Jiang 2023-04-17 @1768 ret = PTR_ERR(qup->irq);
2f61e419c04ee4 Shuai Jiang 2023-04-17 1769 goto fail_dma;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1770
515da746983bc6 Naveen Kaje 2016-10-11 1771 if (has_acpi_companion(qup->dev)) {
515da746983bc6 Naveen Kaje 2016-10-11 1772 ret = device_property_read_u32(qup->dev,
515da746983bc6 Naveen Kaje 2016-10-11 1773 "src-clock-hz", &src_clk_freq);
515da746983bc6 Naveen Kaje 2016-10-11 1774 if (ret) {
515da746983bc6 Naveen Kaje 2016-10-11 1775 dev_notice(qup->dev, "using default src-clock-hz %d",
515da746983bc6 Naveen Kaje 2016-10-11 1776 DEFAULT_SRC_CLK);
515da746983bc6 Naveen Kaje 2016-10-11 1777 }
515da746983bc6 Naveen Kaje 2016-10-11 1778 ACPI_COMPANION_SET(&qup->adap.dev, ACPI_COMPANION(qup->dev));
515da746983bc6 Naveen Kaje 2016-10-11 1779 } else {
10c5a8425968f8 Bjorn Andersson 2014-03-13 1780 qup->clk = devm_clk_get(qup->dev, "core");
10c5a8425968f8 Bjorn Andersson 2014-03-13 1781 if (IS_ERR(qup->clk)) {
10c5a8425968f8 Bjorn Andersson 2014-03-13 1782 dev_err(qup->dev, "Could not get core clock\n");
2f61e419c04ee4 Shuai Jiang 2023-04-17 1783 ret = PTR_ERR(qup->clk);
2f61e419c04ee4 Shuai Jiang 2023-04-17 1784 goto fail_dma;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1785 }
10c5a8425968f8 Bjorn Andersson 2014-03-13 1786
10c5a8425968f8 Bjorn Andersson 2014-03-13 1787 qup->pclk = devm_clk_get(qup->dev, "iface");
10c5a8425968f8 Bjorn Andersson 2014-03-13 1788 if (IS_ERR(qup->pclk)) {
10c5a8425968f8 Bjorn Andersson 2014-03-13 1789 dev_err(qup->dev, "Could not get iface clock\n");
2f61e419c04ee4 Shuai Jiang 2023-04-17 1790 ret = PTR_ERR(qup->pclk);
2f61e419c04ee4 Shuai Jiang 2023-04-17 1791 goto fail_dma;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1792 }
10c5a8425968f8 Bjorn Andersson 2014-03-13 1793 qup_i2c_enable_clocks(qup);
515da746983bc6 Naveen Kaje 2016-10-11 1794 src_clk_freq = clk_get_rate(qup->clk);
515da746983bc6 Naveen Kaje 2016-10-11 1795 }
10c5a8425968f8 Bjorn Andersson 2014-03-13 1796
10c5a8425968f8 Bjorn Andersson 2014-03-13 1797 /*
10c5a8425968f8 Bjorn Andersson 2014-03-13 1798 * Bootloaders might leave a pending interrupt on certain QUP's,
10c5a8425968f8 Bjorn Andersson 2014-03-13 1799 * so we reset the core before registering for interrupts.
10c5a8425968f8 Bjorn Andersson 2014-03-13 1800 */
10c5a8425968f8 Bjorn Andersson 2014-03-13 1801 writel(1, qup->base + QUP_SW_RESET);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1802 ret = qup_i2c_poll_state_valid(qup);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1803 if (ret)
10c5a8425968f8 Bjorn Andersson 2014-03-13 1804 goto fail;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1805
10c5a8425968f8 Bjorn Andersson 2014-03-13 1806 ret = devm_request_irq(qup->dev, qup->irq, qup_i2c_interrupt,
5fe058b04d017a Tian Tao 2021-03-19 1807 IRQF_TRIGGER_HIGH | IRQF_NO_AUTOEN,
5fe058b04d017a Tian Tao 2021-03-19 1808 "i2c_qup", qup);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1809 if (ret) {
10c5a8425968f8 Bjorn Andersson 2014-03-13 1810 dev_err(qup->dev, "Request %d IRQ failed\n", qup->irq);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1811 goto fail;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1812 }
10c5a8425968f8 Bjorn Andersson 2014-03-13 1813
10c5a8425968f8 Bjorn Andersson 2014-03-13 1814 hw_ver = readl(qup->base + QUP_HW_VERSION);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1815 dev_dbg(qup->dev, "Revision %x\n", hw_ver);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1816
10c5a8425968f8 Bjorn Andersson 2014-03-13 1817 io_mode = readl(qup->base + QUP_IO_MODE);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1818
10c5a8425968f8 Bjorn Andersson 2014-03-13 1819 /*
10c5a8425968f8 Bjorn Andersson 2014-03-13 1820 * The block/fifo size w.r.t. 'actual data' is 1/2 due to 'tag'
10c5a8425968f8 Bjorn Andersson 2014-03-13 1821 * associated with each byte written/received
10c5a8425968f8 Bjorn Andersson 2014-03-13 1822 */
10c5a8425968f8 Bjorn Andersson 2014-03-13 1823 size = QUP_OUTPUT_BLOCK_SIZE(io_mode);
3cf357dfb40b4a Pramod Gurav 2014-08-06 1824 if (size >= ARRAY_SIZE(blk_sizes)) {
3cf357dfb40b4a Pramod Gurav 2014-08-06 1825 ret = -EIO;
3cf357dfb40b4a Pramod Gurav 2014-08-06 1826 goto fail;
3cf357dfb40b4a Pramod Gurav 2014-08-06 1827 }
7545c7dba169c4 Abhishek Sahu 2018-03-12 1828 qup->out_blk_sz = blk_sizes[size];
10c5a8425968f8 Bjorn Andersson 2014-03-13 1829
10c5a8425968f8 Bjorn Andersson 2014-03-13 1830 size = QUP_INPUT_BLOCK_SIZE(io_mode);
3cf357dfb40b4a Pramod Gurav 2014-08-06 1831 if (size >= ARRAY_SIZE(blk_sizes)) {
3cf357dfb40b4a Pramod Gurav 2014-08-06 1832 ret = -EIO;
3cf357dfb40b4a Pramod Gurav 2014-08-06 1833 goto fail;
3cf357dfb40b4a Pramod Gurav 2014-08-06 1834 }
7545c7dba169c4 Abhishek Sahu 2018-03-12 1835 qup->in_blk_sz = blk_sizes[size];
7545c7dba169c4 Abhishek Sahu 2018-03-12 1836
7545c7dba169c4 Abhishek Sahu 2018-03-12 1837 if (is_qup_v1) {
7545c7dba169c4 Abhishek Sahu 2018-03-12 1838 /*
7545c7dba169c4 Abhishek Sahu 2018-03-12 1839 * in QUP v1, QUP_CONFIG uses N as 15 i.e 16 bits constitutes a
7545c7dba169c4 Abhishek Sahu 2018-03-12 1840 * single transfer but the block size is in bytes so divide the
7545c7dba169c4 Abhishek Sahu 2018-03-12 1841 * in_blk_sz and out_blk_sz by 2
7545c7dba169c4 Abhishek Sahu 2018-03-12 1842 */
7545c7dba169c4 Abhishek Sahu 2018-03-12 1843 qup->in_blk_sz /= 2;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1844 qup->out_blk_sz /= 2;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1845 qup->write_tx_fifo = qup_i2c_write_tx_fifo_v1;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1846 qup->read_rx_fifo = qup_i2c_read_rx_fifo_v1;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1847 qup->write_rx_tags = qup_i2c_write_rx_tags_v1;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1848 } else {
7545c7dba169c4 Abhishek Sahu 2018-03-12 1849 qup->write_tx_fifo = qup_i2c_write_tx_fifo_v2;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1850 qup->read_rx_fifo = qup_i2c_read_rx_fifo_v2;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1851 qup->write_rx_tags = qup_i2c_write_rx_tags_v2;
7545c7dba169c4 Abhishek Sahu 2018-03-12 1852 }
10c5a8425968f8 Bjorn Andersson 2014-03-13 1853
10c5a8425968f8 Bjorn Andersson 2014-03-13 1854 size = QUP_OUTPUT_FIFO_SIZE(io_mode);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1855 qup->out_fifo_sz = qup->out_blk_sz * (2 << size);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1856
10c5a8425968f8 Bjorn Andersson 2014-03-13 1857 size = QUP_INPUT_FIFO_SIZE(io_mode);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1858 qup->in_fifo_sz = qup->in_blk_sz * (2 << size);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1859
10c5a8425968f8 Bjorn Andersson 2014-03-13 1860 hs_div = 3;
90224e6468e15d Andy Shevchenko 2020-03-24 1861 if (clk_freq <= I2C_MAX_STANDARD_MODE_FREQ) {
71fbafcc45fed7 Austin Christ 2018-05-10 1862 fs_div = ((src_clk_freq / clk_freq) / 2) - 3;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1863 qup->clk_ctl = (hs_div << 8) | (fs_div & 0xff);
71fbafcc45fed7 Austin Christ 2018-05-10 1864 } else {
71fbafcc45fed7 Austin Christ 2018-05-10 1865 /* 33%/66% duty cycle */
71fbafcc45fed7 Austin Christ 2018-05-10 1866 fs_div = ((src_clk_freq / clk_freq) - 6) * 2 / 3;
71fbafcc45fed7 Austin Christ 2018-05-10 1867 qup->clk_ctl = ((fs_div / 2) << 16) | (hs_div << 8) | (fs_div & 0xff);
71fbafcc45fed7 Austin Christ 2018-05-10 1868 }
10c5a8425968f8 Bjorn Andersson 2014-03-13 1869
10c5a8425968f8 Bjorn Andersson 2014-03-13 1870 /*
10c5a8425968f8 Bjorn Andersson 2014-03-13 1871 * Time it takes for a byte to be clocked out on the bus.
10c5a8425968f8 Bjorn Andersson 2014-03-13 1872 * Each byte takes 9 clock cycles (8 bits + 1 ack).
10c5a8425968f8 Bjorn Andersson 2014-03-13 1873 */
10c5a8425968f8 Bjorn Andersson 2014-03-13 1874 one_bit_t = (USEC_PER_SEC / clk_freq) + 1;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1875 qup->one_byte_t = one_bit_t * 9;
ecb6e1e5f43520 Abhishek Sahu 2018-03-12 1876 qup->xfer_timeout = TOUT_MIN * HZ +
6f2f0f6465acbd Abhishek Sahu 2018-03-12 1877 usecs_to_jiffies(MX_DMA_TX_RX_LEN * qup->one_byte_t);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1878
10c5a8425968f8 Bjorn Andersson 2014-03-13 1879 dev_dbg(qup->dev, "IN:block:%d, fifo:%d, OUT:block:%d, fifo:%d\n",
10c5a8425968f8 Bjorn Andersson 2014-03-13 1880 qup->in_blk_sz, qup->in_fifo_sz,
10c5a8425968f8 Bjorn Andersson 2014-03-13 1881 qup->out_blk_sz, qup->out_fifo_sz);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1882
10c5a8425968f8 Bjorn Andersson 2014-03-13 1883 i2c_set_adapdata(&qup->adap, qup);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1884 qup->adap.dev.parent = qup->dev;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1885 qup->adap.dev.of_node = pdev->dev.of_node;
9cedf3b2f09946 Sricharan R 2016-02-22 1886 qup->is_last = true;
f74187932d30e4 Sricharan R 2016-01-19 1887
ea1558ce149d28 Wolfram Sang 2022-08-11 1888 strscpy(qup->adap.name, "QUP I2C adapter", sizeof(qup->adap.name));
10c5a8425968f8 Bjorn Andersson 2014-03-13 1889
10c5a8425968f8 Bjorn Andersson 2014-03-13 1890 pm_runtime_set_autosuspend_delay(qup->dev, MSEC_PER_SEC);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1891 pm_runtime_use_autosuspend(qup->dev);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1892 pm_runtime_set_active(qup->dev);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1893 pm_runtime_enable(qup->dev);
86b59bbfae2a89 Andy Gross 2014-09-29 1894
86b59bbfae2a89 Andy Gross 2014-09-29 1895 ret = i2c_add_adapter(&qup->adap);
86b59bbfae2a89 Andy Gross 2014-09-29 1896 if (ret)
86b59bbfae2a89 Andy Gross 2014-09-29 1897 goto fail_runtime;
86b59bbfae2a89 Andy Gross 2014-09-29 1898
10c5a8425968f8 Bjorn Andersson 2014-03-13 1899 return 0;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1900
86b59bbfae2a89 Andy Gross 2014-09-29 1901 fail_runtime:
86b59bbfae2a89 Andy Gross 2014-09-29 1902 pm_runtime_disable(qup->dev);
86b59bbfae2a89 Andy Gross 2014-09-29 1903 pm_runtime_set_suspended(qup->dev);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1904 fail:
10c5a8425968f8 Bjorn Andersson 2014-03-13 1905 qup_i2c_disable_clocks(qup);
9cedf3b2f09946 Sricharan R 2016-02-22 1906 fail_dma:
9cedf3b2f09946 Sricharan R 2016-02-22 1907 if (qup->btx.dma)
9cedf3b2f09946 Sricharan R 2016-02-22 1908 dma_release_channel(qup->btx.dma);
9cedf3b2f09946 Sricharan R 2016-02-22 1909 if (qup->brx.dma)
9cedf3b2f09946 Sricharan R 2016-02-22 1910 dma_release_channel(qup->brx.dma);
10c5a8425968f8 Bjorn Andersson 2014-03-13 1911 return ret;
10c5a8425968f8 Bjorn Andersson 2014-03-13 1912 }
10c5a8425968f8 Bjorn Andersson 2014-03-13 1913
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Subject: drivers:i2c:busses:i2c-qup.c: Add missing unwind goto in qup_i2c_probe()
2023-04-16 16:41 [PATCH] Subject: drivers:i2c:busses:i2c-qup.c: Add missing unwind goto in qup_i2c_probe() Shuai Jiang
2023-04-16 18:28 ` kernel test robot
@ 2023-04-17 11:02 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-04-17 11:02 UTC (permalink / raw)
To: Shuai Jiang, Andy Gross, Bjorn Andersson, Konrad Dybcio
Cc: llvm, oe-kbuild-all, linux-arm-msm, linux-i2c, linux-kernel,
hust-os-kernel-patches, Shuai Jiang
Hi Shuai,
kernel test robot noticed the following build errors:
[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on linus/master v6.3-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shuai-Jiang/Subject-drivers-i2c-busses-i2c-qup-c-Add-missing-unwind-goto-in-qup_i2c_probe/20230417-004243
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
patch link: https://lore.kernel.org/r/20230416164146.7750-1-d202180596%40hust.edu.cn
patch subject: [PATCH] Subject: drivers:i2c:busses:i2c-qup.c: Add missing unwind goto in qup_i2c_probe()
config: powerpc-randconfig-r032-20230416 (https://download.01.org/0day-ci/archive/20230417/202304171850.t2PGRDnv-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 9638da200e00bd069e6dd63604e14cbafede9324)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/2f61e419c04ee41517d9543a5c6a97e3e392cd5e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Shuai-Jiang/Subject-drivers-i2c-busses-i2c-qup-c-Add-missing-unwind-goto-in-qup_i2c_probe/20230417-004243
git checkout 2f61e419c04ee41517d9543a5c6a97e3e392cd5e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/i2c/busses/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304171850.t2PGRDnv-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/i2c/busses/i2c-qup.c:1768:17: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *' [-Wint-conversion]
ret = PTR_ERR(qup->irq);
^~~~~~~~
include/linux/err.h:29:61: note: passing argument to parameter 'ptr' here
static inline long __must_check PTR_ERR(__force const void *ptr)
^
1 error generated.
vim +1768 drivers/i2c/busses/i2c-qup.c
1656
1657 static int qup_i2c_probe(struct platform_device *pdev)
1658 {
1659 static const int blk_sizes[] = {4, 16, 32};
1660 struct qup_i2c_dev *qup;
1661 unsigned long one_bit_t;
1662 u32 io_mode, hw_ver, size;
1663 int ret, fs_div, hs_div;
1664 u32 src_clk_freq = DEFAULT_SRC_CLK;
1665 u32 clk_freq = DEFAULT_CLK_FREQ;
1666 int blocks;
1667 bool is_qup_v1;
1668
1669 qup = devm_kzalloc(&pdev->dev, sizeof(*qup), GFP_KERNEL);
1670 if (!qup)
1671 return -ENOMEM;
1672
1673 qup->dev = &pdev->dev;
1674 init_completion(&qup->xfer);
1675 platform_set_drvdata(pdev, qup);
1676
1677 if (scl_freq) {
1678 dev_notice(qup->dev, "Using override frequency of %u\n", scl_freq);
1679 clk_freq = scl_freq;
1680 } else {
1681 ret = device_property_read_u32(qup->dev, "clock-frequency", &clk_freq);
1682 if (ret) {
1683 dev_notice(qup->dev, "using default clock-frequency %d",
1684 DEFAULT_CLK_FREQ);
1685 }
1686 }
1687
1688 if (of_device_is_compatible(pdev->dev.of_node, "qcom,i2c-qup-v1.1.1")) {
1689 qup->adap.algo = &qup_i2c_algo;
1690 qup->adap.quirks = &qup_i2c_quirks;
1691 is_qup_v1 = true;
1692 } else {
1693 qup->adap.algo = &qup_i2c_algo_v2;
1694 qup->adap.quirks = &qup_i2c_quirks_v2;
1695 is_qup_v1 = false;
1696 if (acpi_match_device(qup_i2c_acpi_match, qup->dev))
1697 goto nodma;
1698 else
1699 ret = qup_i2c_req_dma(qup);
1700
1701 if (ret == -EPROBE_DEFER)
1702 goto fail_dma;
1703 else if (ret != 0)
1704 goto nodma;
1705
1706 qup->max_xfer_sg_len = (MX_BLOCKS << 1);
1707 blocks = (MX_DMA_BLOCKS << 1) + 1;
1708 qup->btx.sg = devm_kcalloc(&pdev->dev,
1709 blocks, sizeof(*qup->btx.sg),
1710 GFP_KERNEL);
1711 if (!qup->btx.sg) {
1712 ret = -ENOMEM;
1713 goto fail_dma;
1714 }
1715 sg_init_table(qup->btx.sg, blocks);
1716
1717 qup->brx.sg = devm_kcalloc(&pdev->dev,
1718 blocks, sizeof(*qup->brx.sg),
1719 GFP_KERNEL);
1720 if (!qup->brx.sg) {
1721 ret = -ENOMEM;
1722 goto fail_dma;
1723 }
1724 sg_init_table(qup->brx.sg, blocks);
1725
1726 /* 2 tag bytes for each block + 5 for start, stop tags */
1727 size = blocks * 2 + 5;
1728
1729 qup->start_tag.start = devm_kzalloc(&pdev->dev,
1730 size, GFP_KERNEL);
1731 if (!qup->start_tag.start) {
1732 ret = -ENOMEM;
1733 goto fail_dma;
1734 }
1735
1736 qup->brx.tag.start = devm_kzalloc(&pdev->dev, 2, GFP_KERNEL);
1737 if (!qup->brx.tag.start) {
1738 ret = -ENOMEM;
1739 goto fail_dma;
1740 }
1741
1742 qup->btx.tag.start = devm_kzalloc(&pdev->dev, 2, GFP_KERNEL);
1743 if (!qup->btx.tag.start) {
1744 ret = -ENOMEM;
1745 goto fail_dma;
1746 }
1747 qup->is_dma = true;
1748 }
1749
1750 nodma:
1751 /* We support frequencies up to FAST Mode Plus (1MHz) */
1752 if (!clk_freq || clk_freq > I2C_MAX_FAST_MODE_PLUS_FREQ) {
1753 dev_err(qup->dev, "clock frequency not supported %d\n",
1754 clk_freq);
1755 ret = -EINVAL;
1756 goto fail_dma;
1757 }
1758
1759 qup->base = devm_platform_ioremap_resource(pdev, 0);
1760 if (IS_ERR(qup->base))
1761 dev_err(qup->dev, "Could not get qup_i2c_dev base ptr\n");
1762 ret = PTR_ERR(qup->base);
1763 goto fail_dma;
1764
1765 qup->irq = platform_get_irq(pdev, 0);
1766 if (qup->irq < 0)
1767 dev_err(qup->dev, "qup_i2c_dev irq ptr less than zero\n");
> 1768 ret = PTR_ERR(qup->irq);
1769 goto fail_dma;
1770
1771 if (has_acpi_companion(qup->dev)) {
1772 ret = device_property_read_u32(qup->dev,
1773 "src-clock-hz", &src_clk_freq);
1774 if (ret) {
1775 dev_notice(qup->dev, "using default src-clock-hz %d",
1776 DEFAULT_SRC_CLK);
1777 }
1778 ACPI_COMPANION_SET(&qup->adap.dev, ACPI_COMPANION(qup->dev));
1779 } else {
1780 qup->clk = devm_clk_get(qup->dev, "core");
1781 if (IS_ERR(qup->clk)) {
1782 dev_err(qup->dev, "Could not get core clock\n");
1783 ret = PTR_ERR(qup->clk);
1784 goto fail_dma;
1785 }
1786
1787 qup->pclk = devm_clk_get(qup->dev, "iface");
1788 if (IS_ERR(qup->pclk)) {
1789 dev_err(qup->dev, "Could not get iface clock\n");
1790 ret = PTR_ERR(qup->pclk);
1791 goto fail_dma;
1792 }
1793 qup_i2c_enable_clocks(qup);
1794 src_clk_freq = clk_get_rate(qup->clk);
1795 }
1796
1797 /*
1798 * Bootloaders might leave a pending interrupt on certain QUP's,
1799 * so we reset the core before registering for interrupts.
1800 */
1801 writel(1, qup->base + QUP_SW_RESET);
1802 ret = qup_i2c_poll_state_valid(qup);
1803 if (ret)
1804 goto fail;
1805
1806 ret = devm_request_irq(qup->dev, qup->irq, qup_i2c_interrupt,
1807 IRQF_TRIGGER_HIGH | IRQF_NO_AUTOEN,
1808 "i2c_qup", qup);
1809 if (ret) {
1810 dev_err(qup->dev, "Request %d IRQ failed\n", qup->irq);
1811 goto fail;
1812 }
1813
1814 hw_ver = readl(qup->base + QUP_HW_VERSION);
1815 dev_dbg(qup->dev, "Revision %x\n", hw_ver);
1816
1817 io_mode = readl(qup->base + QUP_IO_MODE);
1818
1819 /*
1820 * The block/fifo size w.r.t. 'actual data' is 1/2 due to 'tag'
1821 * associated with each byte written/received
1822 */
1823 size = QUP_OUTPUT_BLOCK_SIZE(io_mode);
1824 if (size >= ARRAY_SIZE(blk_sizes)) {
1825 ret = -EIO;
1826 goto fail;
1827 }
1828 qup->out_blk_sz = blk_sizes[size];
1829
1830 size = QUP_INPUT_BLOCK_SIZE(io_mode);
1831 if (size >= ARRAY_SIZE(blk_sizes)) {
1832 ret = -EIO;
1833 goto fail;
1834 }
1835 qup->in_blk_sz = blk_sizes[size];
1836
1837 if (is_qup_v1) {
1838 /*
1839 * in QUP v1, QUP_CONFIG uses N as 15 i.e 16 bits constitutes a
1840 * single transfer but the block size is in bytes so divide the
1841 * in_blk_sz and out_blk_sz by 2
1842 */
1843 qup->in_blk_sz /= 2;
1844 qup->out_blk_sz /= 2;
1845 qup->write_tx_fifo = qup_i2c_write_tx_fifo_v1;
1846 qup->read_rx_fifo = qup_i2c_read_rx_fifo_v1;
1847 qup->write_rx_tags = qup_i2c_write_rx_tags_v1;
1848 } else {
1849 qup->write_tx_fifo = qup_i2c_write_tx_fifo_v2;
1850 qup->read_rx_fifo = qup_i2c_read_rx_fifo_v2;
1851 qup->write_rx_tags = qup_i2c_write_rx_tags_v2;
1852 }
1853
1854 size = QUP_OUTPUT_FIFO_SIZE(io_mode);
1855 qup->out_fifo_sz = qup->out_blk_sz * (2 << size);
1856
1857 size = QUP_INPUT_FIFO_SIZE(io_mode);
1858 qup->in_fifo_sz = qup->in_blk_sz * (2 << size);
1859
1860 hs_div = 3;
1861 if (clk_freq <= I2C_MAX_STANDARD_MODE_FREQ) {
1862 fs_div = ((src_clk_freq / clk_freq) / 2) - 3;
1863 qup->clk_ctl = (hs_div << 8) | (fs_div & 0xff);
1864 } else {
1865 /* 33%/66% duty cycle */
1866 fs_div = ((src_clk_freq / clk_freq) - 6) * 2 / 3;
1867 qup->clk_ctl = ((fs_div / 2) << 16) | (hs_div << 8) | (fs_div & 0xff);
1868 }
1869
1870 /*
1871 * Time it takes for a byte to be clocked out on the bus.
1872 * Each byte takes 9 clock cycles (8 bits + 1 ack).
1873 */
1874 one_bit_t = (USEC_PER_SEC / clk_freq) + 1;
1875 qup->one_byte_t = one_bit_t * 9;
1876 qup->xfer_timeout = TOUT_MIN * HZ +
1877 usecs_to_jiffies(MX_DMA_TX_RX_LEN * qup->one_byte_t);
1878
1879 dev_dbg(qup->dev, "IN:block:%d, fifo:%d, OUT:block:%d, fifo:%d\n",
1880 qup->in_blk_sz, qup->in_fifo_sz,
1881 qup->out_blk_sz, qup->out_fifo_sz);
1882
1883 i2c_set_adapdata(&qup->adap, qup);
1884 qup->adap.dev.parent = qup->dev;
1885 qup->adap.dev.of_node = pdev->dev.of_node;
1886 qup->is_last = true;
1887
1888 strscpy(qup->adap.name, "QUP I2C adapter", sizeof(qup->adap.name));
1889
1890 pm_runtime_set_autosuspend_delay(qup->dev, MSEC_PER_SEC);
1891 pm_runtime_use_autosuspend(qup->dev);
1892 pm_runtime_set_active(qup->dev);
1893 pm_runtime_enable(qup->dev);
1894
1895 ret = i2c_add_adapter(&qup->adap);
1896 if (ret)
1897 goto fail_runtime;
1898
1899 return 0;
1900
1901 fail_runtime:
1902 pm_runtime_disable(qup->dev);
1903 pm_runtime_set_suspended(qup->dev);
1904 fail:
1905 qup_i2c_disable_clocks(qup);
1906 fail_dma:
1907 if (qup->btx.dma)
1908 dma_release_channel(qup->btx.dma);
1909 if (qup->brx.dma)
1910 dma_release_channel(qup->brx.dma);
1911 return ret;
1912 }
1913
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread