Re: [PATCH] wireless: airo: remove ISA_DMA_API dependency

Simon Horman
2023-04-19T13:40:21Z

On Mon, Apr 17, 2023 at 10:51:24PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This driver does not actually use the ISA DMA API, it is purely
> PIO based, so remove the dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Hi Arnd,

I think that the subject prefix should probably be 'wifi: airo: '.
That nit aside, FWIIW, this looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>

> ---
> drivers/net/wireless/cisco/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/cisco/Kconfig b/drivers/net/wireless/cisco/Kconfig
> index 681bfc2d740a..b40ee25aca99 100644
> --- a/drivers/net/wireless/cisco/Kconfig
> +++ b/drivers/net/wireless/cisco/Kconfig
> @@ -14,7 +14,7 @@ if WLAN_VENDOR_CISCO
>
> config AIRO
> tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
> - depends on CFG80211 && ISA_DMA_API && (PCI || BROKEN)
> + depends on CFG80211 && (PCI || BROKEN)
> select WIRELESS_EXT
> select CRYPTO
> select CRYPTO_SKCIPHER
> --
> 2.39.2
>