* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-18 12:21 [PATCH 5.15 00/91] 5.15.108-rc1 review Greg Kroah-Hartman
@ 2023-04-18 14:47 ` Naresh Kamboju
2023-04-18 16:17 ` Harshit Mogalapalli
2023-04-19 7:24 ` Greg Kroah-Hartman
2023-04-18 20:37 ` Florian Fainelli
` (3 subsequent siblings)
4 siblings, 2 replies; 15+ messages in thread
From: Naresh Kamboju @ 2023-04-18 14:47 UTC (permalink / raw)
To: Greg Kroah-Hartman, Waiman Long
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, Tejun Heo, Michal Koutný,
Daniel Díaz, Anders Roxell
On Tue, 18 Apr 2023 at 18:07, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.15.108 release.
> There are 91 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Following patch causing build break on stable-rc 5.15
> Waiman Long <longman@redhat.com>
> cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Build error:
kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared
(first use in this function); did you mean 'cgroup_put'?
2979 | lockdep_assert_held(&cgroup_mutex);
| ^~~~~~~~~~~~
include/linux/lockdep.h:415:61: note: in definition of macro
'lockdep_assert_held'
415 | #define lockdep_assert_held(l) do {
(void)(l); } while (0)
| ^
kernel/cgroup/cpuset.c:2979:30: note: each undeclared identifier is
reported only once for each function it appears in
2979 | lockdep_assert_held(&cgroup_mutex);
| ^~~~~~~~~~~~
include/linux/lockdep.h:415:61: note: in definition of macro
'lockdep_assert_held'
415 | #define lockdep_assert_held(l) do {
(void)(l); } while (0)
| ^
make[3]: *** [scripts/Makefile.build:289: kernel/cgroup/cpuset.o] Error 1
build log:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.105-280-g0b6a5617247c/testrun/16291026/suite/build/test/gcc-11-lkftconfig-kunit/log
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-18 14:47 ` Naresh Kamboju
@ 2023-04-18 16:17 ` Harshit Mogalapalli
2023-04-18 16:51 ` Tom Saeger
2023-04-19 7:24 ` Greg Kroah-Hartman
1 sibling, 1 reply; 15+ messages in thread
From: Harshit Mogalapalli @ 2023-04-18 16:17 UTC (permalink / raw)
To: Naresh Kamboju, Greg Kroah-Hartman, Waiman Long
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, Tejun Heo, Michal Koutný,
Daniel Díaz, Anders Roxell, Tom Saeger, Darren Kenny,
Vegard Nossum
Hi Greg,
On 18/04/23 8:17 pm, Naresh Kamboju wrote:
> On Tue, 18 Apr 2023 at 18:07, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>>
>> This is the start of the stable review cycle for the 5.15.108 release.
>> There are 91 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc1.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>
>
> Following patch causing build break on stable-rc 5.15
>
>
>> Waiman Long <longman@redhat.com>
>> cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
>
> cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Build error:
> kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared
> (first use in this function); did you mean 'cgroup_put'?
> 2979 | lockdep_assert_held(&cgroup_mutex);
> | ^~~~~~~~~~~~
> include/linux/lockdep.h:415:61: note: in definition of macro
> 'lockdep_assert_held'
> 415 | #define lockdep_assert_held(l) do {
> (void)(l); } while (0)
> | ^
> kernel/cgroup/cpuset.c:2979:30: note: each undeclared identifier is
> reported only once for each function it appears in
> 2979 | lockdep_assert_held(&cgroup_mutex);
> | ^~~~~~~~~~~~
> include/linux/lockdep.h:415:61: note: in definition of macro
> 'lockdep_assert_held'
> 415 | #define lockdep_assert_held(l) do {
> (void)(l); } while (0)
> | ^
> make[3]: *** [scripts/Makefile.build:289: kernel/cgroup/cpuset.o] Error 1
>
>
We observed same build error.(5.15.108-rc1), and investigated about this.
Please see the below findings.
With defconfig --> build breaks.
With allmodconfig --> build succeeds.
From the above we know that this is something related to CONFIG.
In 5.15.y -->
cgroup_mutex is defined like this in include/linux/cgroup.h
#ifdef CONFIG_PROVE_RCU
extern struct mutex cgroup_mutex;
In 6.2.y --> include/linux/cgroup.h
extern struct mutex cgroup_mutex;
-- We don't have that ifdef in 6.2.y.
Tom Saeger identified that the below commit moves it out of ifdef.
commit 354ed597442952fb680c9cafc7e4eb8a76f9514c
Author: Yu Zhao <yuzhao@google.com>
Date: Sun Sep 18 02:00:07 2022 -0600
mm: multi-gen LRU: kill switch
Given that we don't have this commit in 5.15.y and 5.10.y we are seeing
this build problem.
on allmodconfig:
~/linux$ grep "CONFIG_PROVE_RCU" .config
CONFIG_PROVE_RCU=y
CONFIG_PROVE_RCU_LIST=y
on defconfig:
~/linux$ grep "CONFIG_PROVE_RCU" .config
-- No match
This explains the failure on defconfig and a build success on allmodconfig.
Thanks,
Harshit
> build log:
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.105-280-g0b6a5617247c/testrun/16291026/suite/build/test/gcc-11-lkftconfig-kunit/log
>
> --
> Linaro LKFT
> https://lkft.linaro.org
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-18 16:17 ` Harshit Mogalapalli
@ 2023-04-18 16:51 ` Tom Saeger
2023-04-19 4:18 ` Bagas Sanjaya
0 siblings, 1 reply; 15+ messages in thread
From: Tom Saeger @ 2023-04-18 16:51 UTC (permalink / raw)
To: Harshit Mogalapalli
Cc: Naresh Kamboju, Greg Kroah-Hartman, Waiman Long, stable, patches,
linux-kernel, torvalds, akpm, linux, shuah, patches, lkft-triage,
pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw, rwarsow,
Tejun Heo, Michal Koutný, Daniel Díaz, Anders Roxell,
Darren Kenny, Vegard Nossum
On Tue, Apr 18, 2023 at 09:47:33PM +0530, Harshit Mogalapalli wrote:
> Hi Greg,
>
> On 18/04/23 8:17 pm, Naresh Kamboju wrote:
> > On Tue, 18 Apr 2023 at 18:07, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 5.15.108 release.
> > > There are 91 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> >
> > Following patch causing build break on stable-rc 5.15
> >
> >
> > > Waiman Long <longman@redhat.com>
> > > cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> >
> > cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> > commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > Build error:
> > kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> > kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared
> > (first use in this function); did you mean 'cgroup_put'?
> > 2979 | lockdep_assert_held(&cgroup_mutex);
> > | ^~~~~~~~~~~~
> > include/linux/lockdep.h:415:61: note: in definition of macro
> > 'lockdep_assert_held'
> > 415 | #define lockdep_assert_held(l) do {
> > (void)(l); } while (0)
> > | ^
> > kernel/cgroup/cpuset.c:2979:30: note: each undeclared identifier is
> > reported only once for each function it appears in
> > 2979 | lockdep_assert_held(&cgroup_mutex);
> > | ^~~~~~~~~~~~
> > include/linux/lockdep.h:415:61: note: in definition of macro
> > 'lockdep_assert_held'
> > 415 | #define lockdep_assert_held(l) do {
> > (void)(l); } while (0)
> > | ^
> > make[3]: *** [scripts/Makefile.build:289: kernel/cgroup/cpuset.o] Error 1
> >
> >
>
> We observed same build error.(5.15.108-rc1), and investigated about this.
>
> Please see the below findings.
>
> With defconfig --> build breaks.
> With allmodconfig --> build succeeds.
>
> From the above we know that this is something related to CONFIG.
>
> In 5.15.y -->
> cgroup_mutex is defined like this in include/linux/cgroup.h
>
> #ifdef CONFIG_PROVE_RCU
> extern struct mutex cgroup_mutex;
>
> In 6.2.y --> include/linux/cgroup.h
>
> extern struct mutex cgroup_mutex;
>
> -- We don't have that ifdef in 6.2.y.
>
> Tom Saeger identified that the below commit moves it out of ifdef.
>
> commit 354ed597442952fb680c9cafc7e4eb8a76f9514c
> Author: Yu Zhao <yuzhao@google.com>
> Date: Sun Sep 18 02:00:07 2022 -0600
>
> mm: multi-gen LRU: kill switch
>
> Given that we don't have this commit in 5.15.y and 5.10.y we are seeing this
> build problem.
>
> on allmodconfig:
>
> ~/linux$ grep "CONFIG_PROVE_RCU" .config
> CONFIG_PROVE_RCU=y
> CONFIG_PROVE_RCU_LIST=y
>
> on defconfig:
> ~/linux$ grep "CONFIG_PROVE_RCU" .config
> -- No match
>
> This explains the failure on defconfig and a build success on allmodconfig.
>
> Thanks,
> Harshit
>
FWIW - partially backporting (location of cgroup_mutex extern) from:
354ed5974429 ("mm: multi-gen LRU: kill switch")
fixes x86_64 build for me.
Regards,
--Tom
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 45cdb12243e3..460ba084888a 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -433,6 +433,8 @@ static inline void cgroup_put(struct cgroup *cgrp)
css_put(&cgrp->self);
}
+extern struct mutex cgroup_mutex;
+
/**
* task_css_set_check - obtain a task's css_set with extra access conditions
* @task: the task to obtain css_set for
@@ -447,7 +449,6 @@ static inline void cgroup_put(struct cgroup *cgrp)
* as locks used during the cgroup_subsys::attach() methods.
*/
#ifdef CONFIG_PROVE_RCU
-extern struct mutex cgroup_mutex;
extern spinlock_t css_set_lock;
#define task_css_set_check(task, __c) \
rcu_dereference_check((task)->cgroups, \
diff --git a/kernel/cgroup/cgroup-internal.h b/kernel/cgroup/cgroup-internal.h
index d8fcc139ac05..28c32a01da7d 100644
--- a/kernel/cgroup/cgroup-internal.h
+++ b/kernel/cgroup/cgroup-internal.h
@@ -165,7 +165,6 @@ struct cgroup_mgctx {
#define DEFINE_CGROUP_MGCTX(name) \
struct cgroup_mgctx name = CGROUP_MGCTX_INIT(name)
-extern struct mutex cgroup_mutex;
extern spinlock_t css_set_lock;
extern struct cgroup_subsys *cgroup_subsys[];
extern struct list_head cgroup_roots;
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-18 16:51 ` Tom Saeger
@ 2023-04-19 4:18 ` Bagas Sanjaya
2023-04-19 4:56 ` Yu Zhao
0 siblings, 1 reply; 15+ messages in thread
From: Bagas Sanjaya @ 2023-04-19 4:18 UTC (permalink / raw)
To: Tom Saeger, Harshit Mogalapalli, Yu Zhao
Cc: Naresh Kamboju, Greg Kroah-Hartman, Waiman Long, stable, patches,
linux-kernel, torvalds, akpm, linux, shuah, patches, lkft-triage,
pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw, rwarsow,
Tejun Heo, Michal Koutný, Daniel Díaz, Anders Roxell,
Darren Kenny, Vegard Nossum
[-- Attachment #1: Type: text/plain, Size: 2112 bytes --]
On Tue, Apr 18, 2023 at 10:51:05AM -0600, Tom Saeger wrote:
> > Tom Saeger identified that the below commit moves it out of ifdef.
> >
> > commit 354ed597442952fb680c9cafc7e4eb8a76f9514c
> > Author: Yu Zhao <yuzhao@google.com>
> > Date: Sun Sep 18 02:00:07 2022 -0600
> >
> > mm: multi-gen LRU: kill switch
> >
> FWIW - partially backporting (location of cgroup_mutex extern) from:
> 354ed5974429 ("mm: multi-gen LRU: kill switch")
>
> fixes x86_64 build for me.
>
> Regards,
>
> --Tom
>
> diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
> index 45cdb12243e3..460ba084888a 100644
> --- a/include/linux/cgroup.h
> +++ b/include/linux/cgroup.h
> @@ -433,6 +433,8 @@ static inline void cgroup_put(struct cgroup *cgrp)
> css_put(&cgrp->self);
> }
>
> +extern struct mutex cgroup_mutex;
> +
> /**
> * task_css_set_check - obtain a task's css_set with extra access conditions
> * @task: the task to obtain css_set for
> @@ -447,7 +449,6 @@ static inline void cgroup_put(struct cgroup *cgrp)
> * as locks used during the cgroup_subsys::attach() methods.
> */
> #ifdef CONFIG_PROVE_RCU
> -extern struct mutex cgroup_mutex;
> extern spinlock_t css_set_lock;
> #define task_css_set_check(task, __c) \
> rcu_dereference_check((task)->cgroups, \
> diff --git a/kernel/cgroup/cgroup-internal.h b/kernel/cgroup/cgroup-internal.h
> index d8fcc139ac05..28c32a01da7d 100644
> --- a/kernel/cgroup/cgroup-internal.h
> +++ b/kernel/cgroup/cgroup-internal.h
> @@ -165,7 +165,6 @@ struct cgroup_mgctx {
> #define DEFINE_CGROUP_MGCTX(name) \
> struct cgroup_mgctx name = CGROUP_MGCTX_INIT(name)
>
> -extern struct mutex cgroup_mutex;
> extern spinlock_t css_set_lock;
> extern struct cgroup_subsys *cgroup_subsys[];
> extern struct list_head cgroup_roots;
Yu, would you like to provide formal backport? Or maybe take Tom's
diff above and ACK it?
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-19 4:18 ` Bagas Sanjaya
@ 2023-04-19 4:56 ` Yu Zhao
2023-04-19 7:22 ` Greg Kroah-Hartman
2023-04-19 15:09 ` Tom Saeger
0 siblings, 2 replies; 15+ messages in thread
From: Yu Zhao @ 2023-04-19 4:56 UTC (permalink / raw)
To: Bagas Sanjaya, Greg Kroah-Hartman
Cc: Tom Saeger, Harshit Mogalapalli, Naresh Kamboju, Waiman Long,
stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, Tejun Heo, Michal Koutný,
Daniel Díaz, Anders Roxell, Darren Kenny, Vegard Nossum
On Tue, Apr 18, 2023 at 10:18 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Tue, Apr 18, 2023 at 10:51:05AM -0600, Tom Saeger wrote:
> > > Tom Saeger identified that the below commit moves it out of ifdef.
> > >
> > > commit 354ed597442952fb680c9cafc7e4eb8a76f9514c
> > > Author: Yu Zhao <yuzhao@google.com>
> > > Date: Sun Sep 18 02:00:07 2022 -0600
> > >
> > > mm: multi-gen LRU: kill switch
> > >
> > FWIW - partially backporting (location of cgroup_mutex extern) from:
> > 354ed5974429 ("mm: multi-gen LRU: kill switch")
> >
> > fixes x86_64 build for me.
> >
> > Regards,
> >
> > --Tom
> >
> > diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
...
> Yu, would you like to provide formal backport?
Are you suggesting backporting the entire MGLRU patchset (>30 patches)?
I do have the backport ready for 5.15 and multiple distros have taken
it. But I don't think Greg would welcome it. I'd be happy to be wrong
though.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-19 4:56 ` Yu Zhao
@ 2023-04-19 7:22 ` Greg Kroah-Hartman
2023-04-19 8:44 ` Pavel Machek
2023-04-19 15:09 ` Tom Saeger
1 sibling, 1 reply; 15+ messages in thread
From: Greg Kroah-Hartman @ 2023-04-19 7:22 UTC (permalink / raw)
To: Yu Zhao
Cc: Bagas Sanjaya, Tom Saeger, Harshit Mogalapalli, Naresh Kamboju,
Waiman Long, stable, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, Tejun Heo, Michal Koutný,
Daniel Díaz, Anders Roxell, Darren Kenny, Vegard Nossum
On Tue, Apr 18, 2023 at 10:56:22PM -0600, Yu Zhao wrote:
> On Tue, Apr 18, 2023 at 10:18 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> >
> > On Tue, Apr 18, 2023 at 10:51:05AM -0600, Tom Saeger wrote:
> > > > Tom Saeger identified that the below commit moves it out of ifdef.
> > > >
> > > > commit 354ed597442952fb680c9cafc7e4eb8a76f9514c
> > > > Author: Yu Zhao <yuzhao@google.com>
> > > > Date: Sun Sep 18 02:00:07 2022 -0600
> > > >
> > > > mm: multi-gen LRU: kill switch
> > > >
> > > FWIW - partially backporting (location of cgroup_mutex extern) from:
> > > 354ed5974429 ("mm: multi-gen LRU: kill switch")
> > >
> > > fixes x86_64 build for me.
> > >
> > > Regards,
> > >
> > > --Tom
> > >
> > > diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
>
> ...
>
> > Yu, would you like to provide formal backport?
>
> Are you suggesting backporting the entire MGLRU patchset (>30 patches)?
>
> I do have the backport ready for 5.15 and multiple distros have taken
> it. But I don't think Greg would welcome it. I'd be happy to be wrong
> though.
I'm just going to drop all of these patches from the queues now, and let
the original submitter resend them after they are fixed up properly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-19 7:22 ` Greg Kroah-Hartman
@ 2023-04-19 8:44 ` Pavel Machek
0 siblings, 0 replies; 15+ messages in thread
From: Pavel Machek @ 2023-04-19 8:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Yu Zhao, Bagas Sanjaya, Tom Saeger, Harshit Mogalapalli,
Naresh Kamboju, Waiman Long, stable, patches, linux-kernel,
torvalds, akpm, linux, shuah, patches, lkft-triage, pavel,
jonathanh, f.fainelli, sudipm.mukherjee, srw, rwarsow, Tejun Heo,
Michal Koutný, Daniel Díaz, Anders Roxell, Darren Kenny,
Vegard Nossum
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
Hi!
> I'm just going to drop all of these patches from the queues now, and let
> the original submitter resend them after they are fixed up properly.
Build errors are gone in 5.10.178-rc2:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/841747700
and 5.15108-rc2 is okay too:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/841747822
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-19 4:56 ` Yu Zhao
2023-04-19 7:22 ` Greg Kroah-Hartman
@ 2023-04-19 15:09 ` Tom Saeger
2023-04-20 6:47 ` Yu Zhao
1 sibling, 1 reply; 15+ messages in thread
From: Tom Saeger @ 2023-04-19 15:09 UTC (permalink / raw)
To: Yu Zhao
Cc: Bagas Sanjaya, Greg Kroah-Hartman, Harshit Mogalapalli,
Naresh Kamboju, Waiman Long, stable, patches, linux-kernel,
torvalds, akpm, linux, shuah, patches, lkft-triage, pavel,
jonathanh, f.fainelli, sudipm.mukherjee, srw, rwarsow, Tejun Heo,
Michal Koutný, Daniel Díaz, Anders Roxell, Darren Kenny,
Vegard Nossum
On Tue, Apr 18, 2023 at 10:56:22PM -0600, Yu Zhao wrote:
> On Tue, Apr 18, 2023 at 10:18 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> >
> > On Tue, Apr 18, 2023 at 10:51:05AM -0600, Tom Saeger wrote:
> > > > Tom Saeger identified that the below commit moves it out of ifdef.
> > > >
> > > > commit 354ed597442952fb680c9cafc7e4eb8a76f9514c
> > > > Author: Yu Zhao <yuzhao@google.com>
> > > > Date: Sun Sep 18 02:00:07 2022 -0600
> > > >
> > > > mm: multi-gen LRU: kill switch
> > > >
> > > FWIW - partially backporting (location of cgroup_mutex extern) from:
> > > 354ed5974429 ("mm: multi-gen LRU: kill switch")
> > >
> > > fixes x86_64 build for me.
> > >
> > > Regards,
> > >
> > > --Tom
> > >
> > > diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
>
> ...
>
> > Yu, would you like to provide formal backport?
Nah - an easier fix was suggested by Waiman (remove the lockdep_assert_held line) and confirmed here:
https://lore.kernel.org/stable/20230418192807.n3hggjak25tnat7i@oracle.com/
>
> Are you suggesting backporting the entire MGLRU patchset (>30 patches)?
>
> I do have the backport ready for 5.15 and multiple distros have taken
> it.
However, I am interested in testing 5.15 backport of MGLRU.
Where might I find that?
--Tom
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-19 15:09 ` Tom Saeger
@ 2023-04-20 6:47 ` Yu Zhao
0 siblings, 0 replies; 15+ messages in thread
From: Yu Zhao @ 2023-04-20 6:47 UTC (permalink / raw)
To: Tom Saeger; +Cc: linux-kernel
On Wed, Apr 19, 2023 at 9:09 AM Tom Saeger <tom.saeger@oracle.com> wrote:
>
> On Tue, Apr 18, 2023 at 10:56:22PM -0600, Yu Zhao wrote:
> > On Tue, Apr 18, 2023 at 10:18 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> > >
> > > On Tue, Apr 18, 2023 at 10:51:05AM -0600, Tom Saeger wrote:
> > > > > Tom Saeger identified that the below commit moves it out of ifdef.
> > > > >
> > > > > commit 354ed597442952fb680c9cafc7e4eb8a76f9514c
> > > > > Author: Yu Zhao <yuzhao@google.com>
> > > > > Date: Sun Sep 18 02:00:07 2022 -0600
> > > > >
> > > > > mm: multi-gen LRU: kill switch
> > > > >
> > > > FWIW - partially backporting (location of cgroup_mutex extern) from:
> > > > 354ed5974429 ("mm: multi-gen LRU: kill switch")
> > > >
> > > > fixes x86_64 build for me.
> > > >
> > > > Regards,
> > > >
> > > > --Tom
> > > >
> > > > diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
> >
> > ...
> >
> > > Yu, would you like to provide formal backport?
>
> Nah - an easier fix was suggested by Waiman (remove the lockdep_assert_held line) and confirmed here:
>
> https://lore.kernel.org/stable/20230418192807.n3hggjak25tnat7i@oracle.com/
>
> >
> > Are you suggesting backporting the entire MGLRU patchset (>30 patches)?
> >
> > I do have the backport ready for 5.15 and multiple distros have taken
> > it.
>
> However, I am interested in testing 5.15 backport of MGLRU.
> Where might I find that?
git://github.com/yuzhaogoogle/linux mglru-5.15
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-18 14:47 ` Naresh Kamboju
2023-04-18 16:17 ` Harshit Mogalapalli
@ 2023-04-19 7:24 ` Greg Kroah-Hartman
1 sibling, 0 replies; 15+ messages in thread
From: Greg Kroah-Hartman @ 2023-04-19 7:24 UTC (permalink / raw)
To: Naresh Kamboju
Cc: Waiman Long, stable, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, Tejun Heo, Michal Koutný,
Daniel Díaz, Anders Roxell
On Tue, Apr 18, 2023 at 08:17:12PM +0530, Naresh Kamboju wrote:
> On Tue, 18 Apr 2023 at 18:07, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 5.15.108 release.
> > There are 91 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
>
> Following patch causing build break on stable-rc 5.15
>
>
> > Waiman Long <longman@redhat.com>
> > cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
>
> cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Build error:
> kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared
> (first use in this function); did you mean 'cgroup_put'?
> 2979 | lockdep_assert_held(&cgroup_mutex);
> | ^~~~~~~~~~~~
> include/linux/lockdep.h:415:61: note: in definition of macro
> 'lockdep_assert_held'
> 415 | #define lockdep_assert_held(l) do {
> (void)(l); } while (0)
> | ^
> kernel/cgroup/cpuset.c:2979:30: note: each undeclared identifier is
> reported only once for each function it appears in
> 2979 | lockdep_assert_held(&cgroup_mutex);
> | ^~~~~~~~~~~~
> include/linux/lockdep.h:415:61: note: in definition of macro
> 'lockdep_assert_held'
> 415 | #define lockdep_assert_held(l) do {
> (void)(l); } while (0)
> | ^
> make[3]: *** [scripts/Makefile.build:289: kernel/cgroup/cpuset.o] Error 1
>
>
> build log:
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.105-280-g0b6a5617247c/testrun/16291026/suite/build/test/gcc-11-lkftconfig-kunit/log
>
> --
> Linaro LKFT
> https://lkft.linaro.org
I've now dropped the offending patches and pushed out -rc2 releases for
this, and the 5.10.y tree.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-18 12:21 [PATCH 5.15 00/91] 5.15.108-rc1 review Greg Kroah-Hartman
2023-04-18 14:47 ` Naresh Kamboju
@ 2023-04-18 20:37 ` Florian Fainelli
2023-04-18 21:26 ` Shuah Khan
` (2 subsequent siblings)
4 siblings, 0 replies; 15+ messages in thread
From: Florian Fainelli @ 2023-04-18 20:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw, rwarsow
On 4/18/2023 5:21 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.108 release.
> There are 91 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-18 12:21 [PATCH 5.15 00/91] 5.15.108-rc1 review Greg Kroah-Hartman
2023-04-18 14:47 ` Naresh Kamboju
2023-04-18 20:37 ` Florian Fainelli
@ 2023-04-18 21:26 ` Shuah Khan
2023-04-19 3:54 ` Guenter Roeck
2023-04-19 4:23 ` Bagas Sanjaya
4 siblings, 0 replies; 15+ messages in thread
From: Shuah Khan @ 2023-04-18 21:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, Shuah Khan
On 4/18/23 06:21, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.108 release.
> There are 91 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan <skhan@linuxfoundation.org>
Note - I didn't see any build errors.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-18 12:21 [PATCH 5.15 00/91] 5.15.108-rc1 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2023-04-18 21:26 ` Shuah Khan
@ 2023-04-19 3:54 ` Guenter Roeck
2023-04-19 4:23 ` Bagas Sanjaya
4 siblings, 0 replies; 15+ messages in thread
From: Guenter Roeck @ 2023-04-19 3:54 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow
On Tue, Apr 18, 2023 at 02:21:04PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.108 release.
> There are 91 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> Anything received after that time might be too late.
>
Build results:
total: 160 pass: 146 fail: 14
Failed builds:
alpha:allmodconfig
arm:omap2plus_defconfig
arm:vexpress_defconfig
arm64:defconfig
i386:defconfig
ia64:defconfig
mips:defconfig
parisc:allmodconfig
parisc64:generic-64bit_defconfig
powerpc:defconfig
powerpc:ppc64e_defconfig
powerpc:cell_defconfig
s390:defconfig
x86_64:defconfig
Qemu test results:
total: 499 pass: 452 fail: 47
Failed tests:
mipsel64:64r6el_defconfig:notests:nonet:smp:ide:hd
mipsel64:64r6el_defconfig:notests:nonet:smp:ide:hd
mipsel64:64r6el_defconfig:notests:nonet:smp:ide:cd
<all riscv32, riscv64, s390>
Build failures:
kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared
riscv32/riscv64 images crash.
[ 0.000000] Linux version 5.15.108-rc1-00092-g0b6a5617247c (groeck@server.roeck-us.net) (riscv32-linux-gcc (GCC) 11.3.0, GNU ld (GNU Binutils) 2.39) #1 SMP Tue Apr 18 14:19:32 PDT 2023
[ 0.000000] random: crng init done
[ 0.000000] OF: fdt: Ignoring memory range 0x80000000 - 0x80400000
[ 0.000000] Machine model: riscv-virtio,qemu
[ 0.000000] earlycon: uart8250 at MMIO 0x10000000 (options '115200')
[ 0.000000] printk: bootconsole [uart8250] enabled
[ 0.000000] efi: UEFI not found.
[ 0.000000] Unable to handle kernel paging request at virtual address 00600001
[ 0.000000] Oops [#1]
[ 0.000000] Modules linked in:
[ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.15.108-rc1-00092-g0b6a5617247c #1
[ 0.000000] Hardware name: riscv-virtio,qemu (DT)
[ 0.000000] epc : fdt_check_header+0x6/0x1ac
[ 0.000000] ra : __unflatten_device_tree+0x32/0x106
[ 0.000000] epc : c04cf1dc ra : c0859f08 sp : c1c01f30
[ 0.000000] gp : c1d6dca8 tp : c1c0a9c0 t0 : 00000000
[ 0.000000] t1 : c100f4fc t2 : 00000000 s0 : c1c01f40
[ 0.000000] s1 : c0c25000 a0 : 00600000 a1 : 00000000
[ 0.000000] a2 : c1d74044 a3 : c0c253ae a4 : 00000000
[ 0.000000] a5 : c173a000 a6 : c1c01f2c a7 : 00000001
[ 0.000000] s2 : 00600000 s3 : c1d74044 s4 : c0c253ae
[ 0.000000] s5 : 00000000 s6 : 00000000 s7 : 8001b020
[ 0.000000] s8 : 00002000 s9 : 800312e4 s10: 00000000
[ 0.000000] s11: 00000000 t3 : 00000000 t4 : 00000000
[ 0.000000] t5 : a0000000 t6 : 80400000
[ 0.000000] status: 00000100 badaddr: 00600001 cause: 0000000d
[ 0.000000] [<c04cf1dc>] fdt_check_header+0x6/0x1ac
[ 0.000000] ---[ end trace 6977e3ccdb629cdf ]---
[ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task!
Bisect points to
08ace525df14 riscv: Do not set initial_boot_params to the linear address of the dtb
This is not surprising, because that commit says:
"early_init_dt_verify() is already called in parse_dtb() and since the dtb
address does not change anymore (it is now in the fixmap region), no need
to reset initial_boot_params by calling early_init_dt_verify() again.
"
However, the patch which actually moves the early dtb mapping into the
fixmap region was not backported (and looks quite invasive to me).
That makes me wonder ... why is this a stable release candidate in the
first place ?
Guenter
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
2023-04-18 12:21 [PATCH 5.15 00/91] 5.15.108-rc1 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2023-04-19 3:54 ` Guenter Roeck
@ 2023-04-19 4:23 ` Bagas Sanjaya
4 siblings, 0 replies; 15+ messages in thread
From: Bagas Sanjaya @ 2023-04-19 4:23 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On Tue, Apr 18, 2023 at 02:21:04PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.108 release.
> There are 91 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
I have also encountered the same build error as Naresh has reported [1]
when cross-compiling for arm64 (bcm2711_defconfig, GCC 10.2.0).
powerpc (ps3_defconfig, GCC 12.2.0) build isn't affected.
Reported-by: Bagas Sanjaya <bagasdotme@gmail.com>
[1]: https://lore.kernel.org/lkml/CA+G9fYs9sHnfhn4hSFP=AmOfgj-zvoK9vmBejRvzKPj4uXx+VA@mail.gmail.com/
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread