The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Angus Chen <angus.chen@jaguarmicro.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: auxiliary bus: No need to get auxdev->dev again
Date: Tue, 18 Apr 2023 14:32:16 +0200	[thread overview]
Message-ID: <2023041816-magma-shortly-dfdd@gregkh> (raw)
In-Reply-To: <20230418122406.1338-1-angus.chen@jaguarmicro.com>

On Tue, Apr 18, 2023 at 08:24:06PM +0800, Angus Chen wrote:
> Use dev variable directly.
> No functional change intended.

Not intended, but is it really intended?  What does this line mean?

> 
> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> ---
>  drivers/base/auxiliary.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> index 4d4c2c8d26c4..ca1d044ff738 100644
> --- a/drivers/base/auxiliary.c
> +++ b/drivers/base/auxiliary.c
> @@ -286,7 +286,7 @@ int auxiliary_device_init(struct auxiliary_device *auxdev)
>  	}
>  
>  	dev->bus = &auxiliary_bus_type;
> -	device_initialize(&auxdev->dev);
> +	device_initialize(dev);

While an interesting change, is it needed?  Why make it?

thanks,

greg k-h

  reply	other threads:[~2023-04-18 12:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 12:24 [PATCH] driver core: auxiliary bus: No need to get auxdev->dev again Angus Chen
2023-04-18 12:32 ` Greg KH [this message]
2023-04-19  1:02   ` Angus Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023041816-magma-shortly-dfdd@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=angus.chen@jaguarmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox