From: Bjorn Helgaas <helgaas@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-pci@vger.kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-kernel@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Yue Wang" <yue.wang@Amlogic.com>
Subject: Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt
Date: Tue, 18 Apr 2023 13:40:02 -0500 [thread overview]
Message-ID: <20230418184002.GA148053@bhelgaas> (raw)
In-Reply-To: <cdcd04e2-13dc-3dac-daf5-ea784af75467@gmail.com>
On Tue, Apr 18, 2023 at 11:10:39AM -0700, Florian Fainelli wrote:
> On 4/18/23 10:43, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
> > match other PCIe drivers. Capitalize "Meson" to match other Meson Kconfig
> > prompts.
>
> Did you mean, do not capitalize "Meson" or did you intend to preserve the
> previous hunk that had "Meson" capitalized?
I made it match other Meson prompts:
arch/arm/mach-meson/Kconfig- bool "Amlogic Meson6 (8726MX) SoCs support"
drivers/char/hw_random/Kconfig- tristate "Amlogic Meson Random Number Generator support"
drivers/clk/meson/Kconfig- bool "Meson8 SoC Clock controller support"
drivers/gpu/drm/meson/Kconfig- tristate "DRM Support for Amlogic Meson Display Controller"
drivers/i2c/busses/Kconfig- tristate "Amlogic Meson I2C controller"
drivers/iio/adc/Kconfig- tristate "Amlogic Meson SAR ADC driver"
drivers/media/cec/platform/Kconfig- tristate "Amlogic Meson AO CEC driver"
So I guess could have described as "style Meson with initial cap only
instead of all caps" or something.
Bjorn
next prev parent reply other threads:[~2023-04-18 18:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 17:43 [PATCH 0/7] PCI: Tidy controller Kconfig Bjorn Helgaas
2023-04-18 17:43 ` [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt Bjorn Helgaas
2023-04-18 18:10 ` Florian Fainelli
2023-04-18 18:40 ` Bjorn Helgaas [this message]
2023-04-19 18:48 ` Florian Fainelli
2023-04-18 17:43 ` [PATCH 2/7] PCI: hv: Add 'Microsoft' " Bjorn Helgaas
2023-04-19 18:17 ` Wei Liu
2023-04-18 17:43 ` [PATCH 3/7] PCI: xilinx-nwl: Add 'Xilinx' " Bjorn Helgaas
2023-04-19 7:44 ` Michal Simek
2023-04-18 17:43 ` [PATCH 4/7] PCI: Use consistent controller Kconfig menu entry language Bjorn Helgaas
2023-04-18 17:43 ` [PATCH 5/7] PCI: Sort controller Kconfig entries by vendor Bjorn Helgaas
2023-04-18 17:43 ` [PATCH 6/7] PCI: dwc: Sort " Bjorn Helgaas
2023-04-18 17:43 ` [PATCH 7/7] PCI: mobiveil: " Bjorn Helgaas
2023-04-20 19:28 ` [PATCH 0/7] PCI: Tidy controller Kconfig Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418184002.GA148053@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=yue.wang@Amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox