From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD6BFC6FD18 for ; Wed, 19 Apr 2023 13:13:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233362AbjDSNNe (ORCPT ); Wed, 19 Apr 2023 09:13:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232976AbjDSNNc (ORCPT ); Wed, 19 Apr 2023 09:13:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E6B6CC3A; Wed, 19 Apr 2023 06:13:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0976063A36; Wed, 19 Apr 2023 13:13:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16B95C433EF; Wed, 19 Apr 2023 13:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681910010; bh=ZNNHYQW9RITA/JCRpVr8LXHZCHfLZxHZphc4AnU7FAc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tUGn84hvSl+SyKVBIN7bTAF31irVek91ZabWgwhVWBlUJ31XaGroEdQgVxnCJ0U9P 48Hk/7fxIvHja1J/UHhtNzGG5inatvNvN3Z+PTmS/alxgG0UindqN16P4UTA0ljdHj +JOYaiPVVhcEighGmCdj91fvKDeb587dieDahyIo= Date: Wed, 19 Apr 2023 15:13:28 +0200 From: Greg KH To: Rajat Khandelwal Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] usb: typec: intel_pmc_mux: Expose IOM port status to debugfs Message-ID: <2023041928-step-salsa-3cba@gregkh> References: <20230419130345.1689915-1-rajat.khandelwal@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230419130345.1689915-1-rajat.khandelwal@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 19, 2023 at 06:33:45PM +0530, Rajat Khandelwal wrote: > IOM status has a crucial role during debugging to check the > current state of the type-C port. > There are ways to fetch the status, but all those require the > IOM port status offset, which could change with platform. > > Make a debugfs directory for intel_pmc_mux and expose the status > under it per port basis. > > Signed-off-by: Rajat Khandelwal > --- > > v3: Allocate the debugfs directory name for the platform device with > its ACPI dev name included {sigh} No, sorry, this is not correct. Also, you did not properly follow the rules that all Intel kernel developers are supposed to follow. Please consult your local kernel developer team and do so before sending any more kernel patches out. greg k-h