Re: [PATCH v5 6/6] mfd: tps6586x: register restart handler

Lee Jones
2023-04-21T07:25:18Z

On Thu, 20 Apr 2023, Benjamin Bara wrote:

> Thanks for the feedback!
>
> On Thu, 20 Apr 2023 at 16:04, Lee Jones <lee@kernel.org> wrote:
> > Why 20 here and 50 in the other patch?
>
> The data sheet states:
> The device will enter the SLEEP or HARD REBOOT state 10ms after the
> SLEEP REQUEST or REBOOT REQUEST is initiated.
>
> Also:
> When the reboot request state is set an internal timer TWAIT (10ms typ)
> is started (...). The reboot request ends when t > TWAIT.
>
> But in the electrical characteristics, TWAIT is given as min 18, typ 20,
> max 22.
>
> In my observations, reboot took like typ 15ms and sleep typ 25ms, but
> this might be very board-specific. I can set both to 50ms to be "on the
> safe side" and have a common value?

The confusing part for me, the reader, was that both say "will take at
least 10ms" or words to that effect, but they sleep for a different
amount of time.

--
Lee Jones [李琼斯]