Re: [PATCH v5 6/6] mfd: tps6586x: register restart handler

Lee Jones
2023-04-21T07:42:37Z

On Fri, 21 Apr 2023, Benjamin Bara wrote:

> On Fri, 21 Apr 2023 at 09:25, Lee Jones <lee@kernel.org> wrote:
> > The confusing part for me, the reader, was that both say "will take at
> > least 10ms" or words to that effect, but they sleep for a different
> > amount of time.
>
> Yep, got it. For the next version, I will rewrite to:
> "Put the PMIC into * state. Data sheet states that this takes at least 20ms.
> As this is board-specific, add some buffer to prevent the timeout error."
> and change to -ETIMEDOUT instead of -ETIME.

No need to be more verbose.

Stick to the one liner, just be more clear about the timings.

The reader can see that you've added a little buffer without explanation.

--
Lee Jones [李琼斯]