[PATCHSET wq/for-6.5] workqueue: Ordered workqueue creation cleanup

Tejun Heo
2023-04-21T02:50:56Z

Hello,

When multiple work items are queued to a workqueue, their execution order
doesn't match the queueing order. They may get executed in any order and
simultaneously. When fully serialized execution - one by one in the queueing
order - is needed, an ordered workqueue should be used which can be created
with alloc_ordered_workqueue().

However, alloc_ordered_workqueue() was a later addition. Before it, an
ordered workqueue could be obtained by creating an UNBOUND workqueue with
@max_active==1. This originally was an implementation side-effect which was
broken by 4c16bd327c74 ("workqueue: restore WQ_UNBOUND/max_active==1 to be
ordered"). Because there were users that depended on the ordered execution,
5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered")
made workqueue allocation path to implicitly promote UNBOUND workqueues w/
@max_active==1 to ordered workqueues.

While this has worked okay, overloading the UNBOUND allocation interface
this way creates other issues. It's difficult to tell whether a given
workqueue actually needs to be ordered and users that legitimately want a
min concurrency level wq unexpectedly gets an ordered one instead. With
planned UNBOUND workqueue updates to improve execution locality and more
prevalence of chiplet designs which can benefit from such improvements, this
isn't a state we wanna be in forever.

This patch series audits all callsites that create an UNBOUND workqueue w/
@max_active==1 and converts them to alloc_ordered_workqueue() as necessary
and contains the following 22 patches.

0001-powerpc-workqueue-Use-alloc_ordered_workqueue-to-cre.patch
0002-greybus-Use-alloc_ordered_workqueue-to-create-ordere.patch
0003-IB-hfi1-Use-alloc_ordered_workqueue-to-create-ordere.patch
0004-dm-integrity-Use-alloc_ordered_workqueue-to-create-o.patch
0005-media-amphion-Use-alloc_ordered_workqueue-to-create-.patch
0006-net-thunderx-Use-alloc_ordered_workqueue-to-create-o.patch
0007-net-octeontx2-Use-alloc_ordered_workqueue-to-create-.patch
0008-wifi-ath10-11-12k-Use-alloc_ordered_workqueue-to-cre.patch
0009-wifi-iwlwifi-Use-alloc_ordered_workqueue-to-create-o.patch
0010-wifi-mwifiex-Use-alloc_ordered_workqueue-to-create-o.patch
0011-net-wwan-t7xx-Use-alloc_ordered_workqueue-to-create-.patch
0012-scsi-Use-alloc_ordered_workqueue-to-create-ordered-w.patch
0013-virt-acrn-Use-alloc_ordered_workqueue-to-create-orde.patch
0014-soc-qcom-qmi-Use-alloc_ordered_workqueue-to-create-o.patch
0015-xen-pvcalls-Use-alloc_ordered_workqueue-to-create-or.patch
0016-btrfs-Use-alloc_ordered_workqueue-to-create-ordered-.patch
0017-cifs-Use-alloc_ordered_workqueue-to-create-ordered-w.patch
0018-net-qrtr-Use-alloc_ordered_workqueue-to-create-order.patch
0019-rxrpc-Use-alloc_ordered_workqueue-to-create-ordered-.patch
0020-crypto-octeontx2-Use-alloc_ordered_workqueue-to-crea.patch
0021-media-coda-Use-alloc_ordered_workqueue-to-create-ord.patch
0022-workqueue-Don-t-implicitly-make-UNBOUND-workqueues-w.patch

0001-0021 convert the existing users and 0022 drops the implicit ordered
promotion logic from alloc_workqueue(). I'll keep an eye out for a while
after merging 0022. Thankfully, these are pretty easy to grep for. The
patches can also be found in the following git branch.

git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git ordered-cleanup

diffstat follows. Thanks.

arch/powerpc/kernel/tau_6xx.c | 2 -
arch/powerpc/platforms/pseries/dlpar.c | 3 --
drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c | 12 ++++-----
drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c | 6 ++--
drivers/greybus/connection.c | 4 +--
drivers/greybus/svc.c | 2 -
drivers/infiniband/hw/hfi1/init.c | 7 ++---
drivers/md/dm-integrity.c | 4 +--
drivers/md/dm.c | 2 -
drivers/media/platform/amphion/vpu_core.c | 2 -
drivers/media/platform/amphion/vpu_v4l2.c | 2 -
drivers/media/platform/chips-media/coda-common.c | 2 -
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 3 --
drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 5 +---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 13 ++++------
drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 5 +---
drivers/net/wireless/ath/ath10k/qmi.c | 3 --
drivers/net/wireless/ath/ath11k/qmi.c | 3 --
drivers/net/wireless/ath/ath12k/qmi.c | 3 --
drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 4 +--
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 13 ++++------
drivers/net/wireless/marvell/mwifiex/main.c | 22 ++++++++----------
drivers/net/wwan/t7xx/t7xx_hif_cldma.c | 13 +++++-----
drivers/net/wwan/t7xx/t7xx_hif_dpmaif_tx.c | 5 ++--
drivers/scsi/NCR5380.c | 5 +---
drivers/scsi/hosts.c | 12 ++++-----
drivers/scsi/libiscsi.c | 5 +---
drivers/soc/qcom/qmi_interface.c | 2 -
drivers/virt/acrn/ioreq.c | 4 +--
drivers/xen/pvcalls-back.c | 4 +--
fs/btrfs/disk-io.c | 2 -
fs/btrfs/scrub.c | 6 +++-
fs/cifs/dfs_cache.c | 2 -
include/linux/workqueue.h | 4 ---
kernel/workqueue.c | 23 +++----------------
net/qrtr/ns.c | 2 -
net/rxrpc/af_rxrpc.c | 2 -
37 files changed, 92 insertions(+), 121 deletions(-)