From: Lee Jones <lee@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Mark Brown <broonie@kernel.org>,
Martin Botka <martin.botka@somainline.org>,
martin.botka1@gmail.com, Shengyu Qu <wiagn233@outlook.com>,
Samuel Holland <samuel@sholland.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 2/3] mfd: axp20x: Add support for AXP313a PMIC
Date: Fri, 21 Apr 2023 08:31:37 +0100 [thread overview]
Message-ID: <20230421073137.GM996918@google.com> (raw)
In-Reply-To: <20230401001850.4988-3-andre.przywara@arm.com>
On Sat, 01 Apr 2023, Andre Przywara wrote:
> From: Martin Botka <martin.botka@somainline.org>
>
> The AXP313a is a PMIC chip produced by X-Powers, it can be connected via
> an I2C bus.
> The name AXP1530 seems to appear as well, and this is what is used in
> the BSP driver. From all we know it's the same chip, just a different
> name. However we have only seen AXP313a chips in the wild, so go with
> this name.
>
> Compared to the other AXP PMICs it's a rather simple affair: just three
> DCDC converters, three LDOs, and no battery charging support.
>
> Describe the regmap and the MFD bits, along with the registers exposed
> via I2C. Aside from the various regulators, also describe the power key
> interrupts, and adjust the shutdown handler routine to use a different
> register than the other PMICs.
> Eventually advertise the device using the new compatible string.
>
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Acked-for-MFD-by: Lee Jones <lee@kernel.org>
> ---
> drivers/mfd/axp20x-i2c.c | 2 +
> drivers/mfd/axp20x.c | 78 +++++++++++++++++++++++++++++++++++++-
> include/linux/mfd/axp20x.h | 32 ++++++++++++++++
> 3 files changed, 111 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-21 7:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 0:18 [PATCH v10 0/3] regulator: Add X-Powers AXP313a PMIC support Andre Przywara
2023-04-01 0:18 ` [PATCH v10 1/3] dt-bindings: mfd: x-powers,axp152: Document the AXP313a variant Andre Przywara
2023-04-01 19:22 ` Krzysztof Kozlowski
2023-04-02 6:09 ` Chen-Yu Tsai
2023-04-21 7:30 ` Lee Jones
2023-04-01 0:18 ` [PATCH v10 2/3] mfd: axp20x: Add support for AXP313a PMIC Andre Przywara
2023-04-02 6:10 ` Chen-Yu Tsai
2023-04-21 7:31 ` Lee Jones [this message]
2023-04-21 9:35 ` Shengyu Qu
2023-04-24 9:57 ` Lee Jones
2023-04-01 0:18 ` [PATCH v10 3/3] regulator: axp20x: Add support for AXP313a variant Andre Przywara
2023-04-02 6:13 ` Chen-Yu Tsai
2023-04-05 14:21 ` Lee Jones
2023-04-05 15:07 ` Mark Brown
2023-04-05 15:36 ` Lee Jones
2023-04-05 16:15 ` Mark Brown
2023-04-05 16:39 ` Lee Jones
2023-04-05 17:07 ` Mark Brown
2023-04-05 18:03 ` Lee Jones
2023-04-05 18:38 ` Mark Brown
2023-04-06 13:49 ` Mark Brown
2023-04-14 10:32 ` Andre Przywara
2023-04-19 15:49 ` Lee Jones
2023-04-19 16:39 ` Andre Przywara
2023-04-21 7:32 ` [PATCH v10 0/3] regulator: Add X-Powers AXP313a PMIC support Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421073137.GM996918@google.com \
--to=lee@kernel.org \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=martin.botka1@gmail.com \
--cc=martin.botka@somainline.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=wiagn233@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox