Re: [PATCH] ACPI: x86: Separate out the Microsoft _DSM function calls

kernel test robot
2023-04-24T12:20:55Z

config: i386-randconfig-a002-20230424 (https://download.01.org/0day-ci/archive/20230424/202304242025.fz8SDA8d-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/e4ea0d2f15f2d0486bc3b4f59cbf9cea6c63fda1
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Mario-Limonciello/ACPI-x86-Separate-out-the-Microsoft-_DSM-function-calls/20230421-001547
git checkout e4ea0d2f15f2d0486bc3b4f59cbf9cea6c63fda1
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/acpi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304242025.fz8SDA8d-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/acpi/x86/s2idle.c:552:6: warning: no previous prototype for function 'lps0_s2idle_wake' [-Wmissing-prototypes]
bool lps0_s2idle_wake(void)
^
drivers/acpi/x86/s2idle.c:552:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
bool lps0_s2idle_wake(void)
^
static
1 warning generated.

vim +/lps0_s2idle_wake +552 drivers/acpi/x86/s2idle.c

551
> 552 bool lps0_s2idle_wake(void)
553 {
554 if (!lps0_device_handle || sleep_no_lps0)
555 goto out;
556
557 /* avoid running on the first go through the s2idle loop */
558 if (lps0_dsm_func_mask_microsoft > 0) {
559 int target;
560
561 if (lps0_dsm_state == ACPI_LPS0_ENTRY ||
562 lps0_dsm_state == ACPI_LPS0_MS_EXIT)
563 target = ACPI_LPS0_MS_ENTRY;
564 else
565 target = ACPI_LPS0_MS_EXIT;
566 acpi_sleep_run_lps0_dsm(target,
567 lps0_dsm_func_mask_microsoft,
568 lps0_dsm_guid_microsoft);
569 }
570 out:
571 return acpi_s2idle_wake();
572 }
573