From: Lee Jones <lee@kernel.org>
To: Shengyu Qu <wiagn233@outlook.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
wens@csie.org, lgirdwood@gmail.com, broonie@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
andre.przywara@arm.com, conor.dooley@microchip.com
Subject: Re: [PATCH v3 2/3] mfd: axp20x: Add support for AXP15060 PMIC
Date: Wed, 26 Apr 2023 15:27:40 +0100 [thread overview]
Message-ID: <20230426142740.GN50521@google.com> (raw)
In-Reply-To: <TY3P286MB261162D57695AC8164ED50E298609@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
On Fri, 21 Apr 2023, Shengyu Qu wrote:
> The AXP15060 is a PMIC chip produced by X-Powers, and could be connected
> via an I2C bus.
>
> Describe the regmap and the MFD bits, along with the registers exposed
> via I2C. Eventually advertise the device using a new compatible string
> and add support for power off the system.
>
> The driver would disable PEK function if IRQ is not configured in device
> tree, since some boards (For example, Starfive Visionfive 2) didn't
> connect IRQ line of PMIC to SOC.
>
> GPIO function isn't enabled in this commit, since its configuration
> operation is different from any existing AXP PMICs and needs
> logic modification on existing driver. GPIO support might come in later
> patches.
>
> ---
You must not use these above the tags or Git will drop them.
> Changes since v2:
> - Rebase to AXP313a series v10 [1] + newest (20230420) -next branch
> - Add axp_regulator_only_cells rather than directly using axp806_cells
> for cases that IRQ line isn't connected.
>
> Changes since v1:
> - Nothing
>
> [1] https://lore.kernel.org/linux-sunxi/20230401001850.4988-1-andre.przywara@arm.com/
>
> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
> ---
Put change-logs here instead.
> drivers/mfd/axp20x-i2c.c | 2 +
> drivers/mfd/axp20x.c | 107 +++++++++++++++++++++++++++++++++++++
> include/linux/mfd/axp20x.h | 85 +++++++++++++++++++++++++++++
> 3 files changed, 194 insertions(+)
I manually added the missing tags for this and the DT patch and applied.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-26 14:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230421150816.10513-1-wiagn233@outlook.com>
2023-04-21 15:08 ` [PATCH v3 1/3] dt-bindings: mfd: x-powers,axp152: Document the AXP15060 variant Shengyu Qu
2023-04-27 17:19 ` Lee Jones
2023-04-21 15:08 ` [PATCH v3 2/3] mfd: axp20x: Add support for AXP15060 PMIC Shengyu Qu
2023-04-26 14:27 ` Lee Jones [this message]
2023-05-03 11:07 ` Andre Przywara
2023-05-04 6:59 ` Krzysztof Kozlowski
2023-05-15 10:52 ` Lee Jones
2023-05-15 10:55 ` Lee Jones
2023-05-15 14:19 ` Shengyu Qu
2023-05-15 15:10 ` Krzysztof Kozlowski
2023-05-15 15:19 ` Andre Przywara
2023-05-15 15:28 ` Lee Jones
2023-05-15 15:44 ` Shengyu Qu
2023-05-24 0:06 ` Andre Przywara
2023-04-21 15:08 ` [PATCH v3 3/3] regulator: axp20x: Add AXP15060 support Shengyu Qu
2023-04-21 16:28 ` Mark Brown
2023-05-04 7:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426142740.GN50521@google.com \
--to=lee@kernel.org \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wiagn233@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox