From: Lee Jones <lee@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: wm831x: Use maple tree register cache
Date: Thu, 27 Apr 2023 16:11:34 +0100 [thread overview]
Message-ID: <20230427151134.GW50521@google.com> (raw)
In-Reply-To: <20230419-mfd-wm831x-maple-v1-1-e03e39d7bb0b@kernel.org>
On Tue, 25 Apr 2023, Mark Brown wrote:
> regmap has introduced a maple tree based register cache which makes use of
> this more advanced data structure which has been added to the kernel
> recently. Maple trees are much flatter than rbtrees, meaning that they do
> not grow to such depths when the register map is sparse which makes access
> a bit more efficient. The maple tree cache type is still a bit of a work
> in progress but should be effective for some devices already.
>
> The wm831x devices have a pretty sparse register map and being always on
> devices never do cache syncs so don't hit the major current disadvantage
> so they should be good candiates for using the maple tree cache. Update
> to do so, there should be little if any visible difference at runtime.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/mfd/wm831x-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-27 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 18:03 [PATCH] mfd: wm831x: Use maple tree register cache Mark Brown
2023-04-27 9:46 ` Charles Keepax
2023-04-27 15:11 ` Lee Jones [this message]
2023-04-27 15:15 ` Mark Brown
2023-04-27 16:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427151134.GW50521@google.com \
--to=lee@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox