* [PATCH] mfd: rc5t583-irq: Remove the unneeded include <linux/i2c.h>
@ 2023-04-24 6:56 Christophe JAILLET
2023-04-27 16:21 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2023-04-24 6:56 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, kernel-janitors, Christophe JAILLET
This driver does not use i2c, so there is no point in including
<linux/i2c.h>
Remove it and add the needed <linux/device.h> instead, which is much more
lightweight.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/mfd/rc5t583-irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rc5t583-irq.c b/drivers/mfd/rc5t583-irq.c
index 621ea61fa7c6..97f52b671520 100644
--- a/drivers/mfd/rc5t583-irq.c
+++ b/drivers/mfd/rc5t583-irq.c
@@ -8,9 +8,9 @@
* based on code
* Copyright (C) 2011 RICOH COMPANY,LTD
*/
+#include <linux/device.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
-#include <linux/i2c.h>
#include <linux/mfd/rc5t583.h>
enum int_type {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: rc5t583-irq: Remove the unneeded include <linux/i2c.h>
2023-04-24 6:56 [PATCH] mfd: rc5t583-irq: Remove the unneeded include <linux/i2c.h> Christophe JAILLET
@ 2023-04-27 16:21 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-04-27 16:21 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: linux-kernel, kernel-janitors
On Mon, 24 Apr 2023, Christophe JAILLET wrote:
> This driver does not use i2c, so there is no point in including
> <linux/i2c.h>
>
> Remove it and add the needed <linux/device.h> instead, which is much more
> lightweight.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/mfd/rc5t583-irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-27 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-24 6:56 [PATCH] mfd: rc5t583-irq: Remove the unneeded include <linux/i2c.h> Christophe JAILLET
2023-04-27 16:21 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox