Re: [PATCH 1/2] dt-bindings: Add optional gpio property to uartps node to support rs485

Rob Herring
2023-04-27T16:43:59Z

On Wed, Apr 26, 2023 at 05:59:46PM +0530, Manikanta Guntupalli wrote:
> Add optional gpio property to uartps node and add reference to rs485.yaml

The diff tells me that already. Why?

>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> ---
> Documentation/devicetree/bindings/serial/cdns,uart.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> index a8b323d7bf94..34ed0d80b923 100644
> --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> @@ -46,6 +46,10 @@ properties:
> power-domains:
> maxItems: 1
>
> + txrx-gpios:
> + description: Optional GPIO to switch transmit and receive modes via pmod.

What's pmod?

> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -55,6 +59,7 @@ required:
>
> allOf:
> - $ref: serial.yaml#
> + - $ref: rs485.yaml#
> - if:
> properties:
> compatible:
> --
> 2.25.1
>