From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2070C77B60 for ; Fri, 28 Apr 2023 17:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230015AbjD1RGE (ORCPT ); Fri, 28 Apr 2023 13:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjD1RGA (ORCPT ); Fri, 28 Apr 2023 13:06:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DED002694 for ; Fri, 28 Apr 2023 10:05:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A4D5644C2 for ; Fri, 28 Apr 2023 17:05:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52ECCC433D2; Fri, 28 Apr 2023 17:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682701558; bh=PBNgi24wLhulSF0zuj6iMWeLEm97lHhM6E5QUQLKk3o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TCYBDwRJ0dzlVXBN4iA/ohH3nPhKEeoAux3MMWX6gRNTNzzR55VTo2dAldmWdCRrM 2LYZoFENr0kx8IVk9D/whEz37pOlSUCL3flWEBJcM2xPI0Y2T/XqOYo3Zs6vU1Np8s I3VA5s6Ko4xbmBlabtxEVozLLDFhlCgzT9qdhGIQATRXjdlfG1iDRum+a0DIA9d7+S QvSRqFYboBy1GkGyEzePbtYr08Y5bkrMBvRSg1kxoRFd11YEyB21Cj4MW3rxgYFY6n Zc02bduRKLXALq6qi8G4eZC+6C0bJw1mysndoksvtCsQYIk70gafm05h9FEKPMyM37 lb2Wb254b8XrQ== Date: Fri, 28 Apr 2023 18:05:53 +0100 From: Conor Dooley To: Yangyu Chen Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Rob Herring , Krzysztof Kozlowski , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones , Wende Tan , Soha Jin , Hongren Zheng , Conor Dooley Subject: Re: [PATCH v2 2/2] dt-bindings: riscv: drop invalid comment about riscv,isa lower-case reasoning Message-ID: <20230428-repacking-percolate-79be27947af6@spud> References: <20230428141601.678489-1-cyy@cyyself.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="duh32IVum06IkP5O" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --duh32IVum06IkP5O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 28, 2023 at 10:16:01PM +0800, Yangyu Chen wrote: > From: Conor Dooley >=20 > "Ease of parsing" may have been the initial argument for keeping this > string in lower-case, but parsers may have been written that expect > lower-case only. > For example, the one in released kernels currently does not behave > correctly for multi-letter extensions that begin with a capital letter. > Allowing upper-case here brings about no benefit but would break > compatibility between new devicetrees and older kernels. >=20 > Drop the comment to avoid confusing people. >=20 > Signed-off-by: Conor Dooley You missed an Acked-by from Rob here: https://lore.kernel.org/all/168261158214.3107331.4410018416833510357.robh@k= ernel.org/ Also, when you are submitting a patch authored by another person, you need to append your Signed-off-by to the patch ;) Cheers, Conor. > --- > Documentation/devicetree/bindings/riscv/cpus.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/riscv/cpus.yaml b/Document= ation/devicetree/bindings/riscv/cpus.yaml > index 001931d526ec..1ee97621d0c7 100644 > --- a/Documentation/devicetree/bindings/riscv/cpus.yaml > +++ b/Documentation/devicetree/bindings/riscv/cpus.yaml > @@ -81,7 +81,7 @@ properties: > =20 > While the isa strings in ISA specification are case > insensitive, letters in the riscv,isa string must be all > - lowercase to simplify parsing. > + lowercase. > $ref: "/schemas/types.yaml#/definitions/string" > pattern: ^rv(?:64|32)imaf?d?q?c?b?k?j?p?v?h?(?:[hsxz](?:[a-z])+)?(?:= _[hsxz](?:[a-z])+)*$ > =20 > --=20 > 2.40.0 >=20 --duh32IVum06IkP5O Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZEv88QAKCRB4tDGHoIJi 0jmsAP99ehYUNjIbvjxkbNmAqoqscoLdD0claGcn5TvVuJyyTAD+P2K++thvAX97 EKhJQedy4RCGdCPiHbW3eqRL5fjwyQI= =bqeQ -----END PGP SIGNATURE----- --duh32IVum06IkP5O--