Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

Thomas Zimmermann
2023-04-28T13:12:02Z

[-- Attachment #1.1: Type: text/plain, Size: 912 bytes --]

Hi

Am 28.04.23 um 14:27 schrieb Geert Uytterhoeven:
[...]
>
> In addition, the non-raw variants may do some extras to guarantee
> ordering, which you do not need on a frame buffer.

Given this comment, should we declare the fb_() helpers in
<asm-generic/io.h> or <linux/io.h>?

I still don't like the idea of having the functions in <linux/fb.h>. We
have code in DRM that also accesses framebuffer memory (via
memcpy_toio()). It would make sense to use the fb_() helpers, if they
are tailored towards this usecase.

Best regards
Thomas

>
> So I'd go for the __raw_*() variants everywhere.
>
> Gr{oetje,eeting}s,
>
> Geert
>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]