From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D300C77B7C for ; Sat, 29 Apr 2023 13:36:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230495AbjD2Ngk (ORCPT ); Sat, 29 Apr 2023 09:36:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbjD2Ngi (ORCPT ); Sat, 29 Apr 2023 09:36:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34BA6198A for ; Sat, 29 Apr 2023 06:36:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BB46760A16 for ; Sat, 29 Apr 2023 13:36:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7345C433D2; Sat, 29 Apr 2023 13:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682775396; bh=qR5z2S05PO+3Qj7DWNNQjQe9q0aiW2MJANgGn+LsPHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=enTorLCTDVjxvuv4kRHNsvkzVUJCSFBqlCcEvNS8dfSuysh6UVBSUy8eLvdHyRk4k +aOKGUO6qZLblTpetG6GGrkb3Ro+Fv66ZxDTkQbw/51dxEXaIlR+k15NCmpQ7rtuih PHyXlFIQ+EzVUzZziiRDZsOlzgXgW5vh0UPywFrV1WHe2p0tcX8DN3KIASWRTwt5xd abb65x3cDqPYR+Ey+4UP7Vi8Ifk5FayVRU28yzBnXyHyj+dXfB+AkWdLB+xYpFur50 GEMk8GfPCkM3NPitOFT3BuYRB1UPZw0ObL9D4InzqkSRY0mGqRu+9xiZK+h8tLwT/b yUwo3pTPnbThA== Date: Sat, 29 Apr 2023 14:36:31 +0100 From: Conor Dooley To: Evan Green Cc: Palmer Dabbelt , Albert Ou , Andrew Jones , Conor Dooley , Heiko Stuebner , Jisheng Zhang , Palmer Dabbelt , Paul Walmsley , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 2/3] RISC-V: Track ISA extensions per hart Message-ID: <20230429-record-plunder-a21cf40d4cee@spud> References: <20230428190609.3239486-1-evan@rivosinc.com> <20230428190609.3239486-3-evan@rivosinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BLU7QsAwGsxIomG5" Content-Disposition: inline In-Reply-To: <20230428190609.3239486-3-evan@rivosinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --BLU7QsAwGsxIomG5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 28, 2023 at 12:06:07PM -0700, Evan Green wrote: > @@ -112,14 +116,17 @@ void __init riscv_fill_hwcap(void) > bitmap_zero(riscv_isa, RISCV_ISA_EXT_MAX); > =20 > for_each_of_cpu_node(node) { > + struct riscv_isainfo *isainfo; > unsigned long this_hwcap =3D 0; > - DECLARE_BITMAP(this_isa, RISCV_ISA_EXT_MAX); > const char *temp; > + unsigned int cpu_id; > =20 > rc =3D riscv_of_processor_hartid(node, &hartid); > if (rc < 0) > continue; > =20 > + cpu_id =3D riscv_hartid_to_cpuid(hartid); > + isainfo =3D &hart_isa[cpu_id]; > if (of_property_read_string(node, "riscv,isa", &isa)) { Would you mind adding a blank line above the if statement please? Otherwise, Reviewed-by: Conor Dooley Thanks, Conor. > pr_warn("Unable to find \"riscv,isa\" devicetree entry\n"); > continue; --BLU7QsAwGsxIomG5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZE0dSQAKCRB4tDGHoIJi 0gsnAQD3C7wPGlXJpnjjDLb+5iaR4064+DeCKq1zwwCZmkbK2QEAulHfubOOEb14 bOcIpu2YKL/pjU13yG9aPi38S9/RUwk= =b/Lb -----END PGP SIGNATURE----- --BLU7QsAwGsxIomG5--