From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E45C7EE26 for ; Sat, 29 Apr 2023 01:59:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347322AbjD2B67 (ORCPT ); Fri, 28 Apr 2023 21:58:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347158AbjD2B6z (ORCPT ); Fri, 28 Apr 2023 21:58:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4EE11738; Fri, 28 Apr 2023 18:58:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F7FE6413C; Sat, 29 Apr 2023 01:58:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9FD7C433EF; Sat, 29 Apr 2023 01:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682733533; bh=g8i1cvnrJTprc6jL7uG9qN1A5swdSdlan7Q+tB1GZx0=; h=From:To:Cc:Subject:Date:From; b=AHgk7+ogGSEwhK12mMTIkn9Z/hVe3tsmcSwUiZb/oPzO1ZdNGwmdvEMQC5XhFuoyB vj3sFfOhV2qZCykpdHFtv6iorv9yhVIW5H/gNMnTqBXG3nbM/3Dm6ucJYpF267PbqV ismdIRyi7Q3v68lhyOr6wxzFXwWlecZTiSgoDfalDocn+UN5LAnxp5/ZTSevAE+fTp m6YPa65lHf54jfVTuPXfFLw3yAeVkNvmmdp/7lv5uZL+mEFyX0plTprboHWC/bmj// m6VqpkCbe1W82kAfqUyuiAv3vB/Z6R44/KPm8S38L5Kd+XPQszGgPxA9KZmfyK9214 t4nBBTrjIycjw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Paul E. McKenney" , Boqun Feng , Sasha Levin , dave@stgolabs.net, josh@joshtriplett.org, frederic@kernel.org, quic_neeraju@quicinc.com, rcu@vger.kernel.org Subject: [PATCH AUTOSEL 6.3 1/3] refscale: Move shutdown from wait_event() to wait_event_idle() Date: Fri, 28 Apr 2023 21:58:48 -0400 Message-Id: <20230429015850.3027243-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Paul E. McKenney" [ Upstream commit 6bc6e6b27524304aadb9c04611ddb1c84dd7617a ] The ref_scale_shutdown() kthread/function uses wait_event() to wait for the refscale test to complete. However, although the read-side tests are normally extremely fast, there is no law against specifying a very large value for the refscale.loops module parameter or against having a slow read-side primitive. Either way, this might well trigger the hung-task timeout. This commit therefore replaces those wait_event() calls with calls to wait_event_idle(), which do not trigger the hung-task timeout. Signed-off-by: Paul E. McKenney Signed-off-by: Boqun Feng Signed-off-by: Sasha Levin --- kernel/rcu/refscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/refscale.c b/kernel/rcu/refscale.c index afa3e1a2f6902..1970ce5f22d40 100644 --- a/kernel/rcu/refscale.c +++ b/kernel/rcu/refscale.c @@ -1031,7 +1031,7 @@ ref_scale_cleanup(void) static int ref_scale_shutdown(void *arg) { - wait_event(shutdown_wq, shutdown_start); + wait_event_idle(shutdown_wq, shutdown_start); smp_mb(); // Wake before output. ref_scale_cleanup(); -- 2.39.2