Re: [PATCH v1 2/2] Bluetooth: hci_qca: Add qcomm devcoredump support

[kernel test robot <lkp@intel.com>]

Hi Sai,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bluetooth/master]
[also build test WARNING on bluetooth-next/master linus/master v6.3 next-20230428]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sai-Teja-Aluvala/Bluetooth-hci_qca-Add-qcomm-devcoredump-support/20230428-152145
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link:    https://lore.kernel.org/r/1682666311-8452-1-git-send-email-quic_saluvala%40quicinc.com
patch subject: [PATCH v1 2/2] Bluetooth: hci_qca: Add qcomm devcoredump support
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230429/202304290720.TfpPCFY6-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/a3c3d43057a99f13198754e0b8eaf944d1853142
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sai-Teja-Aluvala/Bluetooth-hci_qca-Add-qcomm-devcoredump-support/20230428-152145
        git checkout a3c3d43057a99f13198754e0b8eaf944d1853142
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304290720.TfpPCFY6-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/bluetooth/hci_qca.c:981:5: warning: no previous prototype for 'qca_dmp_hdr' [-Wmissing-prototypes]
     981 | int qca_dmp_hdr(struct hci_dev *hdev, char *buf, size_t size)
         |     ^~~~~~~~~~~
   drivers/bluetooth/hci_qca.c: In function 'qca_controller_memdump':
   drivers/bluetooth/hci_qca.c:1070:31: error: implicit declaration of function 'hci_devcoredump_init' [-Werror=implicit-function-declaration]
    1070 |                         ret = hci_devcoredump_init(hu->hdev, qca_memdump->ram_dump_size);
         |                               ^~~~~~~~~~~~~~~~~~~~
   drivers/bluetooth/hci_qca.c:1119:25: error: implicit declaration of function 'hci_devcoredump_append_pattern' [-Werror=implicit-function-declaration]
    1119 |                         hci_devcoredump_append_pattern(hu->hdev, 0x00,
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/bluetooth/hci_qca.c:1136:25: error: implicit declaration of function 'hci_devcoredump_append' [-Werror=implicit-function-declaration]
    1136 |                         hci_devcoredump_append(hu->hdev, skb);
         |                         ^~~~~~~~~~~~~~~~~~~~~~
   drivers/bluetooth/hci_qca.c:1150:25: error: implicit declaration of function 'hci_devcoredump_complete' [-Werror=implicit-function-declaration]
    1150 |                         hci_devcoredump_complete(hu->hdev);
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/bluetooth/hci_qca.c: In function 'qca_hw_error':
   drivers/bluetooth/hci_qca.c:1557:17: error: implicit declaration of function 'hci_devcoredump_abort' [-Werror=implicit-function-declaration]
    1557 |                 hci_devcoredump_abort(hu->hdev);
         |                 ^~~~~~~~~~~~~~~~~~~~~
   drivers/bluetooth/hci_qca.c: In function 'hciqca_coredump_enabled':
   drivers/bluetooth/hci_qca.c:1727:32: error: 'struct device' has no member named 'coredump_disabled'
    1727 |         return !hu->serdev->dev.coredump_disabled;
         |                                ^
   drivers/bluetooth/hci_qca.c: In function 'qca_setup':
   drivers/bluetooth/hci_qca.c:1866:25: error: 'struct hci_dev' has no member named 'dump'
    1866 |                 hu->hdev->dump.enabled = hciqca_coredump_enabled;
         |                         ^~
   drivers/bluetooth/hci_qca.c:1906:9: error: implicit declaration of function 'hci_devcoredump_register' [-Werror=implicit-function-declaration]
    1906 |         hci_devcoredump_register(hdev, hci_coredump_qca, qca_dmp_hdr, NULL);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/bluetooth/hci_qca.c: In function 'hciqca_coredump':
   drivers/bluetooth/hci_qca.c:2458:17: error: 'struct device' has no member named 'coredump_disabled'
    2458 |         if (!dev->coredump_disabled && hdev->dump.coredump)
         |                 ^~
   drivers/bluetooth/hci_qca.c:2458:44: error: 'struct hci_dev' has no member named 'dump'
    2458 |         if (!dev->coredump_disabled && hdev->dump.coredump)
         |                                            ^~
   drivers/bluetooth/hci_qca.c:2459:21: error: 'struct hci_dev' has no member named 'dump'
    2459 |                 hdev->dump.coredump(hdev);
         |                     ^~
   cc1: some warnings being treated as errors


vim +/qca_dmp_hdr +981 drivers/bluetooth/hci_qca.c

   980	
 > 981	int qca_dmp_hdr(struct hci_dev *hdev, char *buf, size_t size)
   982	{
   983		struct hci_uart *hu = hci_get_drvdata(hdev);
   984		struct qca_data *qca = hu->priv;
   985		int len = 0;
   986	
   987		len += snprintf(buf + len, size-len, "Controller Name: 0x%x\n",
   988				qca->controller_id);
   989	
   990		len += snprintf(buf + len, size-len, "Firmware Version: 0x%x\n",
   991				qca->fw_version);
   992	
   993		len += snprintf(buf + len, size-len, "Vendor:Qualcomm\n");
   994	
   995		len += snprintf(buf + len, size-len, "Driver: %s\n",
   996				hu->serdev->dev.driver->name);
   997	
   998		bt_dev_info(hdev, "vendor dump hdr size(%d)", len);
   999		return len;
  1000	}
  1001	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests