From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2339C77B7F for ; Mon, 1 May 2023 02:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232374AbjEAC6z (ORCPT ); Sun, 30 Apr 2023 22:58:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232260AbjEAC62 (ORCPT ); Sun, 30 Apr 2023 22:58:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5371319A4; Sun, 30 Apr 2023 19:57:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2693160EB3; Mon, 1 May 2023 02:57:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4C5EC433EF; Mon, 1 May 2023 02:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682909877; bh=IQgHuOoRnkEGD1Jb5Lkm537dUiI0uLn05CysAyCGk+c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b4PEpUtfmqDkIfWsdNDvk/iM+cCRDQWfro01h32t65rRoOwQh1lmLN5TnOw16yraE ipwOzeZhXEAhuDDvB9iZ++Dr4KCqLqjVn1vlLDWC5Ia6DZEcPcrZKHGfNy2ClksmZq K+kLTKsZU3PgA+u7aiGliDYohkq1zzVxvHUiPbsM5sHIp36Gfokk5saY5WzDKnbCZz S+JQPghvBtSTD+29Yr2oHiejgeF0ZFLTGCN4HWk0tP5R/F0JZvGBxPafnZaSt+n1e6 ixylZcNB2oBuDgVyHHo4FEkA+M3yrWIlRtQ9n3rSSuuq/NHoNTqWPj/C2h3husjExZ b9ln/rt/CVUOw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kang Chen , "Rafael J . Wysocki" , Sasha Levin , rafael@kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH AUTOSEL 6.3 18/44] ACPI: processor: Check for null return of devm_kzalloc() in fch_misc_setup() Date: Sun, 30 Apr 2023 22:56:06 -0400 Message-Id: <20230501025632.3253067-18-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501025632.3253067-1-sashal@kernel.org> References: <20230501025632.3253067-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kang Chen [ Upstream commit 4dea41775d951ff1f7b472a346a8ca3ae7e74455 ] devm_kzalloc() may fail, clk_data->name might be NULL and will cause a NULL pointer dereference later. Signed-off-by: Kang Chen [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpi_apd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 3bbe2276cac76..80f945cbec8a7 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -83,6 +83,8 @@ static int fch_misc_setup(struct apd_private_data *pdata) if (!acpi_dev_get_property(adev, "clk-name", ACPI_TYPE_STRING, &obj)) { clk_data->name = devm_kzalloc(&adev->dev, obj->string.length, GFP_KERNEL); + if (!clk_data->name) + return -ENOMEM; strcpy(clk_data->name, obj->string.pointer); } else { -- 2.39.2