Re: [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT

Arnd Bergmann
2023-03-14T15:47:31Z

On Tue, Mar 14, 2023, at 15:17, Geert Uytterhoeven wrote:
>> --- a/drivers/char/Kconfig
>> +++ b/drivers/char/Kconfig
>> @@ -34,6 +34,7 @@ config TTY_PRINTK_LEVEL
>> config PRINTER
>> tristate "Parallel printer support"
>> depends on PARPORT
>> + depends on HAS_IOPORT
>
> This looks wrong to me.
> drivers/char/lp.c uses the parport API, no direct I/O port access.

It looks like include/linux/parport.h requires I/O port access
when PARPORT_PC is enabled and PARPORT_NOT_PC is disabled.
Maybe this would work:

depends on PARPORT
depends on HAS_IOPORT || PARPORT_NOT_PC

Arnd