Re: [PATCH v3 13/38] Input: add HAS_IOPORT dependencies

Niklas Schnelle
2023-04-28T14:50:53Z

On Wed, 2023-03-15 at 09:22 +0100, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Tue, Mar 14, 2023 at 1:12 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote:
> > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> > not being declared. We thus need to add HAS_IOPORT as dependency for
> > those drivers using them.
> >
> > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
>
> Thanks for your patch!
>
> > --- a/drivers/input/serio/Kconfig
> > +++ b/drivers/input/serio/Kconfig
> > @@ -75,6 +75,7 @@ config SERIO_Q40KBD
> > config SERIO_PARKBD
> > tristate "Parallel port keyboard adapter"
> > depends on PARPORT
> > + depends on HAS_IOPORT
> > help
> > Say Y here if you built a simple parallel port adapter to attach
> > an additional AT keyboard, XT keyboard or PS/2 mouse.
>
> This driver seems to use only the parport and serio APIs, so it might
> work on systems without HAS_IOPORT. Dunno for sure.
>
> Gr{oetje,eeting}s,
>
> Geert
>

Thanks, yes you're right this driver compiles fine without inb()/outb()
etc. I removed the dependency, not sure if it used to have a dependency
or this was a mixup but it's corrected for v4.

Thanks,
Niklas