From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA10C7EE22 for ; Tue, 2 May 2023 18:12:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233610AbjEBSM1 (ORCPT ); Tue, 2 May 2023 14:12:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233523AbjEBSMZ (ORCPT ); Tue, 2 May 2023 14:12:25 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CEC4197; Tue, 2 May 2023 11:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683051143; x=1714587143; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=U0sG9yZo/74wvsF1+m0dJT/5G45+XpYD3sb3gmNWYeA=; b=XLcnJYuPFZpejUhF9d5ecgD5vD/HU2nBxtBv4bJC+KBE0ZFAwjE5dTsh UPlJQMTyC4U5SdfmasDXGGPWzntNHwhRJ2xgjE62O/bxi2p1TMLrk6EI4 NglTMEkRaeuRW8MTC35u3QDHJs3YvrNegTJv8pZsvVPeA63ZiOyW5unUb A9zLG2TZ8Kl/rzXyzlSOKXSgeJN/MaxvHzq320YT9UzWNI62Pg74LID98 ZicJD4s+w0tS7grvMzlSP0RQy37Hztg1ofCPVV0V9YmarMo3jnbqONN2K sT5s44Vtpo2mMULPePdacfDXshhPRvzeISdoGiVCrmzeD6Pm/5MTRk9XJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10698"; a="347292910" X-IronPort-AV: E=Sophos;i="5.99,244,1677571200"; d="scan'208";a="347292910" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2023 11:08:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10698"; a="696288855" X-IronPort-AV: E=Sophos;i="5.99,244,1677571200"; d="scan'208";a="696288855" Received: from lkp-server01.sh.intel.com (HELO e3434d64424d) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 02 May 2023 11:08:33 -0700 Received: from kbuild by e3434d64424d with local (Exim 4.96) (envelope-from ) id 1ptuQS-0001Ca-1k; Tue, 02 May 2023 18:08:32 +0000 Date: Wed, 3 May 2023 02:07:42 +0800 From: kernel test robot To: Ajay Kaher , rostedt@goodmis.org, mhiramat@kernel.org, shuah@kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, chinglinyu@google.com, namit@vmware.com, srivatsab@vmware.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, vsirnapalli@vmware.com, tkundu@vmware.com, er.ajay.kaher@gmail.com, Ajay Kaher Subject: Re: [PATCH v2 8/9] eventfs: moving tracing/events to eventfs Message-ID: <202305030116.Gu6yyvKj-lkp@intel.com> References: <1683026600-13485-9-git-send-email-akaher@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1683026600-13485-9-git-send-email-akaher@vmware.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ajay, kernel test robot noticed the following build warnings: [auto build test WARNING on shuah-kselftest/next] [also build test WARNING on shuah-kselftest/fixes linus/master v6.3 next-20230428] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ajay-Kaher/eventfs-introducing-struct-tracefs_inode/20230502-192949 base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next patch link: https://lore.kernel.org/r/1683026600-13485-9-git-send-email-akaher%40vmware.com patch subject: [PATCH v2 8/9] eventfs: moving tracing/events to eventfs config: i386-randconfig-a011-20230501 (https://download.01.org/0day-ci/archive/20230503/202305030116.Gu6yyvKj-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/2fe2002efb23a715f5eb7a58891ff85f4e37b084 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Ajay-Kaher/eventfs-introducing-struct-tracefs_inode/20230502-192949 git checkout 2fe2002efb23a715f5eb7a58891ff85f4e37b084 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash kernel/trace/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305030116.Gu6yyvKj-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/trace/trace_events.c:2424:17: warning: variable 'd_events' set but not used [-Wunused-but-set-variable] struct dentry *d_events; ^ 1 warning generated. vim +/d_events +2424 kernel/trace/trace_events.c ac343da7bc9048 Masami Hiramatsu 2020-09-10 2417 1473e4417c79f1 Steven Rostedt 2009-02-24 2418 static int 7f1d2f8210195c Steven Rostedt (Red Hat 2015-05-05 2419) event_create_dir(struct dentry *parent, struct trace_event_file *file) 1473e4417c79f1 Steven Rostedt 2009-02-24 2420 { 2425bcb9240f8c Steven Rostedt (Red Hat 2015-05-05 2421) struct trace_event_call *call = file->event_call; ae63b31e4d0e2e Steven Rostedt 2012-05-03 2422 struct trace_array *tr = file->tr; 2fe2002efb23a7 Ajay Kaher 2023-05-02 2423 struct eventfs_file *ef_subsystem = NULL; ae63b31e4d0e2e Steven Rostedt 2012-05-03 @2424 struct dentry *d_events; de7b2973903c6c Mathieu Desnoyers 2014-04-08 2425 const char *name; fd99498989f3b3 Steven Rostedt 2009-02-28 2426 int ret; 1473e4417c79f1 Steven Rostedt 2009-02-24 2427 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2428 /* 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2429 * If the trace point header did not define TRACE_SYSTEM 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2430 * then the system would be called "TRACE_SYSTEM". 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2431 */ ae63b31e4d0e2e Steven Rostedt 2012-05-03 2432 if (strcmp(call->class->system, TRACE_SYSTEM) != 0) { 2fe2002efb23a7 Ajay Kaher 2023-05-02 2433 ef_subsystem = event_subsystem_dir(tr, call->class->system, file, parent); 2fe2002efb23a7 Ajay Kaher 2023-05-02 2434 if (!ef_subsystem) ae63b31e4d0e2e Steven Rostedt 2012-05-03 2435 return -ENOMEM; ae63b31e4d0e2e Steven Rostedt 2012-05-03 2436 } else ae63b31e4d0e2e Steven Rostedt 2012-05-03 2437 d_events = parent; 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2438 687fcc4aee4567 Steven Rostedt (Red Hat 2015-05-13 2439) name = trace_event_name(call); 2fe2002efb23a7 Ajay Kaher 2023-05-02 2440 file->ef = eventfs_add_dir(name, ef_subsystem, &tr->eventfs_rwsem); 2fe2002efb23a7 Ajay Kaher 2023-05-02 2441 if (IS_ERR(file->ef)) { 8434dc9340cd2e Steven Rostedt (Red Hat 2015-01-20 2442) pr_warn("Could not create tracefs '%s' directory\n", name); 1473e4417c79f1 Steven Rostedt 2009-02-24 2443 return -1; 1473e4417c79f1 Steven Rostedt 2009-02-24 2444 } 1473e4417c79f1 Steven Rostedt 2009-02-24 2445 9b63776fa3ca96 Steven Rostedt 2012-05-10 2446 if (call->class->reg && !(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE)) 2fe2002efb23a7 Ajay Kaher 2023-05-02 2447 eventfs_add_file("enable", TRACE_MODE_WRITE, file->ef, file, 620a30e97febc8 Oleg Nesterov 2013-07-31 2448 &ftrace_enable_fops); 1473e4417c79f1 Steven Rostedt 2009-02-24 2449 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests