Re: [PATCH blktests v3 10/12] nvme/rc: Calculate IO size for random fio jobs

Daniel Wagner
2023-05-10T17:15:02Z

On Sun, May 07, 2023 at 11:31:10PM +0000, Shinichiro Kawasaki wrote:
> - _xfs_run_fio_verify_io /dev/"${nvmedev}n1" "1m" || echo FAIL
> > + rand_io_size="$(_nvme_calc_rand_io_size 4M)"
> > + _run_fio_rand_io --filename="/dev/${nvmedev}n1" --size="${rand_io_size}"
>
> Here, _xfs_run_fio_verify_io is replaced with _run_fio_rand_io. May I confirm
> that this replacement does not affect this test case? Same question for the hunk
> below.

This is on purpose. The test just wants only verify that IO is still working.
Because _xfs_run_fio_verify_io has the minimum requirement of 350M for
nvme_img_size. When I wrote the test I didn't know this and thus this change.

I'll update the commit message to include this info.