Re: [PATCH blktests v3 11/12] nvme/rc: Move discovery generation counter code to rc

Daniel Wagner
2023-05-10T17:25:38Z

On Sun, May 07, 2023 at 11:34:51PM +0000, Shinichiro Kawasaki wrote:
> On May 03, 2023 / 10:02, Daniel Wagner wrote:
> > Move the discovery generation counter code to rc so that we can reuse
> > it in 002.
>
> The last #12 patch no longer touches nvme/002, then I'm not so sure this patch
> is valuable. IMO, the lengthy 002.out has the role to check all of the 1000
> times discoveries are successful. So it looks the better to keep current
> nvme/002 as is.

While we don't update the counter anymore, I still think it's worthwhile to
do some cleanup. We have two tests which do the same thing so why not use common
code?