From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F683C77B75 for ; Wed, 3 May 2023 15:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbjECPWm (ORCPT ); Wed, 3 May 2023 11:22:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjECPWk (ORCPT ); Wed, 3 May 2023 11:22:40 -0400 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78A72526B for ; Wed, 3 May 2023 08:22:38 -0700 (PDT) Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-61b71b7803bso6517526d6.1 for ; Wed, 03 May 2023 08:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1683127357; x=1685719357; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z72RIdKmaEAHhQSJvbUggUruDGfXxzyBpebhinUUrDk=; b=5re4CQifcjgd9jxTsVO9hmhw6XMxMZLnn+9npz6K1XjDCQ8FvkKJE3X6Yw4GkTPAGM FbvGtFkH/d+NJOWM3Q1x6nZoFb+jc+X8Taw5QBSs/hEhgEe+ZMp3MaxCwjyd40CQGqNw 4BSbRR9FgKVb4EOoP1w+l1ybPqbF97tlvZuF4TaFYkQL/CYHpgxlM6rgsnGHDzYuMMh/ p2+7dkbgEiMBIT2eGpcMqkT+SfAnDGxDaz8/+6M91ysZaSwycbmKeyYg6ZpkUy1Mg6Sw fcLO/8PJqzpX0w1KpblmJPgjHfSzQH/BAYHMESvYMfGj9F95/wfgCms82p8c6UwSNs3o 0P1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683127357; x=1685719357; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z72RIdKmaEAHhQSJvbUggUruDGfXxzyBpebhinUUrDk=; b=XQvfv2gVIs6j9yW9aV5bIzXZwfrbBeQR0WIkYjbjO3ks6kGEV/DJ0ckZSd5qgvN3Q1 A17RI10YMtzy97yT5GwEZofP4DFiqTka0Z4mygEeuFrfg6WDWqZ0fGeq1fwNZtf+3eO/ o4noqtEDK+iN5SGuL+jCWhx2K+EZYB/LwvIVPH2GoOjcm2em3icvKBgzwm7C+UjjySBV r8l/Eyz4keV3C7eoZNGdQrY/2X/2gE1cv8H9HDSLz3lAOWvHRSRt2rd5XPIPPgq7XkQ9 SyqqfQfA/x5/UsN1JHpxAW3Li/HI3AaevWDjSByGp/5eNGWC8rmk9PJnwqNzpai5BWB4 EDrA== X-Gm-Message-State: AC+VfDzmiJuif9cqIEdM71ysaMWIxnrqRB5dHt4hxBBWnOEc0bYS5Cg2 pt1zjiY8qgnOF/1TyArYS2YQCw== X-Google-Smtp-Source: ACHHUZ6fGMSFqnaJplKEuCgOeeUB553kYejp5VFW8TunnY7roEmjKtyUeC1wrv92nnbOwFt/+39Z3w== X-Received: by 2002:ad4:5ba6:0:b0:5b9:3f17:b219 with SMTP id 6-20020ad45ba6000000b005b93f17b219mr9586749qvq.3.1683127357643; Wed, 03 May 2023 08:22:37 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id w8-20020a05620a444800b0074e026a6a43sm10732751qkp.9.2023.05.03.08.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 08:22:37 -0700 (PDT) Date: Wed, 3 May 2023 11:22:36 -0400 From: Johannes Weiner To: Nhat Pham Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, willy@infradead.org, linux-api@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v13 3/3] selftests: Add selftests for cachestat Message-ID: <20230503152236.GD193380@cmpxchg.org> References: <20230503013608.2431726-1-nphamcs@gmail.com> <20230503013608.2431726-4-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230503013608.2431726-4-nphamcs@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 02, 2023 at 06:36:08PM -0700, Nhat Pham wrote: > Test cachestat on a newly created file, /dev/ files, and /proc/ files. > Also test on a shmem file (which can also be tested with huge pages > since tmpfs supports huge pages). > > Signed-off-by: Nhat Pham *and a directory Looks good to me. It covers a good set of real cases and weird cases. Acked-by: Johannes Weiner