From: "hch@lst.de" <hch@lst.de>
To: Jinyoung CHOI <j-young.choi@samsung.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/15] block: blk-integiry: add helper functions for bio_integrity_add_page
Date: Wed, 3 May 2023 17:55:01 +0200 [thread overview]
Message-ID: <20230503155501.GB31700@lst.de> (raw)
In-Reply-To: <20230503100220epcms2p33e69fd7d5f04b305c621799792e8155f@epcms2p3>
s/blk-integiry/blk-integrity/ in the subject.
> +static inline bool bip_full(struct bio_integrity_payload *bip, unsigned int len)
> +static bool bip_try_merge_hw_seg(struct request_queue *q,
> + struct bio_integrity_payload *bip,
> + struct page *page, unsigned int len,
> + unsigned int offset, bool *same_page)
... but adding static functions without users will cause a compile
error anyway, so I'd suggest to just merge it into the patch adding
users.
But I wonder if we really want to duplicate all this logic anyway.
If we passed a bio_vec array, the vec count and an iter, we should
be able to just share the logic with the bio data payload.
next prev parent reply other threads:[~2023-05-03 15:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230503094912epcms2p4bef206eab1c41a92eba2583a69c74323@epcms2p4>
2023-05-03 9:49 ` [PATCH 00/15] Change the integrity configuration method in block Jinyoung CHOI
2023-05-03 10:00 ` [PATCH 01/15] block: bio: rename page_is_mergeable to bio_page_is_mergeable and make non-static Jinyoung CHOI
2023-05-03 15:52 ` hch
2023-05-04 6:24 ` Jinyoung CHOI
2023-05-03 10:02 ` [PATCH 02/15] block: blk-integiry: add helper functions for bio_integrity_add_page Jinyoung CHOI
2023-05-03 15:55 ` hch [this message]
2023-05-04 6:46 ` Jinyoung CHOI
2023-05-03 10:06 ` [PATCH 03/15] block: bio-integrity: modify bio_integrity_add_page() Jinyoung CHOI
2023-05-03 10:09 ` [PATCH 04/15] block: bio-integiry: cleanup bio_integrity_prep Jinyoung CHOI
2023-05-03 15:55 ` hch
2023-05-03 10:10 ` [PATCH 05/15] block: fix not to apply bip information in blk_rq_bio_prep() Jinyoung CHOI
2023-05-03 12:56 ` kernel test robot
2023-05-03 15:57 ` hch
2023-05-04 6:10 ` Jinyoung CHOI
2023-05-03 17:23 ` kernel test robot
2023-05-03 19:06 ` kernel test robot
2023-05-03 10:12 ` [PATCH 06/15] block: blk-merge: fix to add the number of integrity segments to the request twice Jinyoung CHOI
2023-05-03 10:13 ` [PATCH 07/15] block: blk-merge: fix merging two requests in ll_merge_requests_fn Jinyoung CHOI
2023-05-03 10:16 ` [PATCH 08/15] block: add helper function to get the number of integrity segments Jinyoung CHOI
2023-05-03 10:18 ` [PATCH 09/15] scsi: add scsi_alloc_integrity_sgtables() for integrity process Jinyoung CHOI
2023-05-03 10:20 ` [PATCH 10/15] scsi: change to use blk_rq_nr_integrity_segments() instead of blk_rq_count_integrity_sg() Jinyoung CHOI
2023-05-03 10:21 ` [PATCH 11/15] block: blk-integrity: change how to find the number of integrity of bio Jinyoung CHOI
2023-05-03 10:23 ` [PATCH 12/15] nvme: rdma: change how to find the number of integrity of request Jinyoung CHOI
2023-05-03 10:25 ` [PATCH 13/15] block: add helper function for iteration of bip's bvec Jinyoung CHOI
2023-05-03 10:27 ` [PATCH 14/15] block: blk-integrity: change sg-table configuration method for integrity Jinyoung CHOI
2023-05-03 14:29 ` kernel test robot
2023-05-03 20:07 ` kernel test robot
2023-05-03 10:28 ` [PATCH 15/15] block: blk-integrity: remove blk_rq_count_integrity_sg() Jinyoung CHOI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503155501.GB31700@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=j-young.choi@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox