Re: [PATCH v4 1/4] block: Introduce provisioning primitives

Sarthak Kukreti
2023-04-20T17:42:21Z

Dropped in v5.

Thanks!
Sarthak

On Tue, Apr 18, 2023 at 3:43 PM Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 4/18/23 15:12, Sarthak Kukreti wrote:
> > /* Fail if we don't recognize the flags. */
> > - if (mode & ~BLKDEV_FALLOC_FL_SUPPORTED)
> > + if (mode != 0 && mode & ~BLKDEV_FALLOC_FL_SUPPORTED)
> > return -EOPNOTSUPP;
>
> Is this change necessary? Doesn't (mode & ~BLKDEV_FALLOC_FL_SUPPORTED)
> != 0 imply that mode != 0?
>
> Thanks,
>
> Bart.
>