From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31CB8C77B78 for ; Thu, 4 May 2023 20:08:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232861AbjEDUH7 (ORCPT ); Thu, 4 May 2023 16:07:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233121AbjEDUFz (ORCPT ); Thu, 4 May 2023 16:05:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 495FD1155C; Thu, 4 May 2023 12:53:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B72F63871; Thu, 4 May 2023 19:52:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 383AEC433A0; Thu, 4 May 2023 19:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683229959; bh=XK2jckxn7goA5rrfx5GMbq6wI1FUq3RW3PpLAeR04DA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LDGE1sC4rWpfdPJvVOI4EpKmIwomgFzSkl4wdtx0/u21zB9sztv566dtV8TK208qL 5Q6lqNcH2+sWBHWk4wI3YB+wEr9RLl7PjngYtr5GIDyITrTySfKM3+7f5Ujz93R9LI MarZTfEzbqHgPRPTxJG95lgGg+AkZJx/ZL9VKDqlOEp0bWkBXgPXtzTROPtS04hAhT qEZ3vrUHDtUnkZ5jCIeg+jbzeD8APO5SAIBqMs5Xnh7dst9LwdMg+ki1nKYGqC406D VoYlh/eAL0Crtno+Se2A4KnZi4W/qw1sywN8Fgk8/FdKvXLxnMIlayyCSJYuc+YZAj 6XSF7gPG6hcDw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Min Li , syzbot+9519d6b5b79cf7787cf3@syzkaller.appspotmail.com, Luiz Augusto von Dentz , Sasha Levin , marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 13/13] Bluetooth: L2CAP: fix "bad unlock balance" in l2cap_disconnect_rsp Date: Thu, 4 May 2023 15:52:05 -0400 Message-Id: <20230504195207.3809116-13-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230504195207.3809116-1-sashal@kernel.org> References: <20230504195207.3809116-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Min Li [ Upstream commit 25e97f7b1866e6b8503be349eeea44bb52d661ce ] conn->chan_lock isn't acquired before l2cap_get_chan_by_scid, if l2cap_get_chan_by_scid returns NULL, then 'bad unlock balance' is triggered. Reported-by: syzbot+9519d6b5b79cf7787cf3@syzkaller.appspotmail.com Link: https://lore.kernel.org/all/000000000000894f5f05f95e9f4d@google.com/ Signed-off-by: Min Li Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- net/bluetooth/l2cap_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 6f47cb69775d6..b0bb4cf52a7ee 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -4392,7 +4392,6 @@ static inline int l2cap_disconnect_rsp(struct l2cap_conn *conn, chan = l2cap_get_chan_by_scid(conn, scid); if (!chan) { - mutex_unlock(&conn->chan_lock); return 0; } -- 2.39.2