Re: [PATCH v2 4/6] spi: sun6i: add support for R329 SPI controllers

Andre Przywara
2023-05-06T21:59:27Z

On Sat, 6 May 2023 10:30:12 +0300
Maksim Kiselev <bigunclemax@gmail.com> wrote:

> From: Icenowy Zheng <icenowy@aosc.io>
>
> R329 has two SPI controllers. One of it is quite similar to previous
> ones, but with internal clock divider removed; the other added MIPI DBI
> Type-C offload based on the first one.
>
> Add basical support for these controllers. As we're not going to
> support the DBI functionality now, just implement the two kinds of
> controllers as the same.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> drivers/spi/spi-sun6i.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
> index 82523011a3a5..fe287a45df9b 100644
> --- a/drivers/spi/spi-sun6i.c
> +++ b/drivers/spi/spi-sun6i.c
> @@ -715,9 +715,21 @@ static const struct sun6i_spi_cfg sun8i_h3_spi_cfg = {
> .has_clk_ctl = true,
> };
>
> +static const struct sun6i_spi_cfg sun50i_r329_spi_cfg = {
> + .fifo_depth = SUN8I_FIFO_DEPTH,
> +};
> +
> static const struct of_device_id sun6i_spi_match[] = {
> { .compatible = "allwinner,sun6i-a31-spi", .data = &sun6i_a31_spi_cfg },
> { .compatible = "allwinner,sun8i-h3-spi", .data = &sun8i_h3_spi_cfg },
> + {
> + .compatible = "allwinner,sun50i-r329-spi",
> + .data = &sun50i_r329_spi_cfg
> + },
> + {
> + .compatible = "allwinner,sun50i-r329-spi-dbi",
> + .data = &sun50i_r329_spi_cfg
> + },

As mentioned by others, we would not need to mention this compatible
string in the driver, the fallback string in the DT should take care
of the detection.

Rest looks fine.

Cheers,
Andre

> {}
> };
> MODULE_DEVICE_TABLE(of, sun6i_spi_match);