From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C6749C7EE22
	for <linux-kernel@archiver.kernel.org>; Tue,  9 May 2023 02:00:43 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233849AbjEICAm (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 8 May 2023 22:00:42 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51448 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229539AbjEICAj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 May 2023 22:00:39 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88CE340F7
        for <linux-kernel@vger.kernel.org>; Mon,  8 May 2023 19:00:38 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 10ABA64382
        for <linux-kernel@vger.kernel.org>; Tue,  9 May 2023 02:00:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA072C433D2;
        Tue,  9 May 2023 02:00:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1683597637;
        bh=9MHSuy4IZwbNpLTmIOSNzbAG86M7TJ8YGI6Ot3dbBD8=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=IGR7vZCKE5peiS9ezikYTMTLap5LlBbO5nmTWRfpNZi2mUMI8OY3+wI3nVCe6pZeS
         VaZNU5bAUmSSMLeItyGXpBeNQj1kXEMVOOY3XGK4bG2xxRsCitZ/OuOOF0kTNDc73t
         KtrhAdquktLgZ6lTPdy32aVz9MViMCb2q6ErXVqmVhY7W7t9OmH8+cWSMFoThaGvnN
         4/sBMY74Ez+FxqThj0JwiOr0mYIZTlyJ14RSW9IhU4Ed80mixjoHJ39+cx/lwFBsJv
         +wJByvFDGvDQvKqIiyXBLRefhZkA7OrTAscF/oOXLoMRhl/PPrXeTfT+PK+lyD+PZZ
         V5fga8hc2wjzw==
Date:   Mon, 8 May 2023 19:00:35 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Siddharth Vadapalli <s-vadapalli@ti.com>
Cc:     <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <srk@ti.com>
Subject: Re: [PATCH net] net: phy: dp83867: add w/a for packet errors seen
 with short cables
Message-ID: <20230508190035.24b5710e@kernel.org>
In-Reply-To: <20230508070019.356548-1-s-vadapalli@ti.com>
References: <20230508070019.356548-1-s-vadapalli@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for the patch! Some nit picks below..

On Mon, 8 May 2023 12:30:19 +0530 Siddharth Vadapalli wrote:
> +	err = phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_DSP_FFE_CFG, 0X0E81);

Pleas wrap this line at 80 characters, there's no reason for it 
to be this long.

And 0x prefix should not be in upper case, here and in the new define
you're adding.
-- 
pw-bot: cr